? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
26 Oct 2019

Summary of Changes

Adapting the code to the new featured_down and featured_up columns in _content_frontpage table.

Testing Instructions

Install a brand new 4.0-dev.
Install some languages (French fr-FR, German de-DE)
Use the Multilingual Sample Data installation in Control Panel

Before patch

The installation stops at step 6

After patch

All is fine

Screen Shot 2019-10-26 at 18 30 41

avatar infograf768 infograf768 - open - 26 Oct 2019
avatar infograf768 infograf768 - change - 26 Oct 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Oct 2019
Category Front End Plugins
avatar Quy Quy - test_item - 26 Oct 2019 - Tested successfully
avatar Quy
Quy - comment - 26 Oct 2019

I have tested this item successfully on 0e02619


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26832.

avatar richard67
richard67 - comment - 26 Oct 2019

@infograf768 @Quy I get here on a current 4.0-dev with the patch applied after a new installation and then having installed German (DE) and French following PHP notice 2 times, and the multilingaul sample data still stops at step 6:

PHP Notice: Undefined property: Joomla\Component\Content\Administrator\Table\ArticleTable::$featured_up in /home/richard/lamp/public_html/joomla-cms-4.0-dev/libraries/src/Table/Content.php on line 278

avatar Quy
Quy - comment - 26 Oct 2019

I forgot to mention I had to install your PR #26829 first before applying this PR.

avatar richard67
richard67 - comment - 26 Oct 2019

Ah, I see. Will do so, too.

avatar richard67
richard67 - comment - 26 Oct 2019

@infograf768 @Quy Wouldn't it be safer to include this change here into my PR #26829 ? It could be a problem if this one here gets merged long before #26829 .

avatar Quy
Quy - comment - 26 Oct 2019

Good idea!

avatar richard67 richard67 - test_item - 26 Oct 2019 - Tested successfully
avatar richard67
richard67 - comment - 26 Oct 2019

I have tested this item successfully on 0e02619

Requires PR #26829 to be applied, too.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26832.

avatar infograf768 infograf768 - change - 26 Oct 2019
Labels Added: ?
avatar richard67 richard67 - test_item - 26 Oct 2019 - Tested successfully
avatar richard67
richard67 - comment - 26 Oct 2019

I have tested this item successfully on 098800e

Requires PR #26829 to be applied, too, and requires that PR to be merged before this here.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26832.

avatar infograf768
infograf768 - comment - 27 Oct 2019

When i tested (and I did it again a minute ago), I did not have #26829 applied and the patch worked fine.
The Notice does appear in logs but can be treated separately and is unrelated to this PR.

avatar infograf768 infograf768 - change - 27 Oct 2019
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 27 Oct 2019

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26832.

avatar infograf768 infograf768 - change - 27 Oct 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 27 Oct 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-10-27 22:02:18
Closed_By wilsonge
avatar wilsonge wilsonge - close - 27 Oct 2019
avatar wilsonge wilsonge - merge - 27 Oct 2019
avatar wilsonge
wilsonge - comment - 27 Oct 2019

Thanks!

Add a Comment

Login with GitHub to post a comment