?
avatar Quy
Quy
26 Oct 2019

Steps to reproduce the issue

@richard67

Log in administration control panel.
Check PHP error log.

PHP Notice:  Undefined property: Joomla\Component\Content\Administrator\Table\ArticleTable::$featured_up in \libraries\src\Table\Content.php on line 278
PHP Notice:  Undefined index: featured_up in \administrator\components\com_content\Model\ArticleModel.php on line 950
PHP Notice:  Undefined index: featured_down in \administrator\components\com_content\Model\ArticleModel.php on line 950
avatar Quy Quy - open - 26 Oct 2019
avatar joomla-cms-bot joomla-cms-bot - change - 26 Oct 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 26 Oct 2019
avatar richard67
richard67 - comment - 26 Oct 2019

Seems to be related to e5a67c2.

avatar richard67
richard67 - comment - 26 Oct 2019

@Quy But I could not reproduce. Is your database up to date with the commit I've linked in my previous comment?

avatar richard67
richard67 - comment - 26 Oct 2019

@Quy Look in that commit here: e5a67c2#diff-db94a7a8f9f1edf368d10d7b96302889R948. There is no check isset($data['featured_up'] or isset($data['featured_up']. Could that be the problem?

avatar Quy
Quy - comment - 26 Oct 2019

I did a refresh install (not using PatchTester) of the latest dev branch after PR #25979 was merged.

avatar richard67
richard67 - comment - 26 Oct 2019

I did the same. Just doing it again.

avatar richard67
richard67 - comment - 26 Oct 2019

Still can't reproduce.

avatar richard67
richard67 - comment - 26 Oct 2019

@Quy You're testing on Windows? I see backslashes in your error log. I'm testing on Linux. Maybe that's the difference???

avatar richard67
richard67 - comment - 26 Oct 2019

But what could cause that then? Only a recent change in class names regarding upper and lower case affecting this function and not working with Windows ... I don't remember such thing. So the only other thing could be differences in database? I have no idea.

avatar Quy
Quy - comment - 26 Oct 2019

Yes on Windows.

Installing the Blog Sample Data results in There is an error in a sample data plugin. Response is invalid..

avatar richard67
richard67 - comment - 26 Oct 2019

Sample data is known issue as far as I remember. Unfortunately I don't have Windows testing environment to reproduce.

avatar Quy
Quy - comment - 26 Oct 2019

Know issue with Testing Sample Data, but not with Blog Sample Data.

Here is line 278. It is missing the null check.

if ($this->featured_up && $this->featured_down && $this->featured_down < $this->featured_up)
avatar richard67
richard67 - comment - 26 Oct 2019

278 where?

avatar richard67
richard67 - comment - 26 Oct 2019

ahh got it

avatar richard67
richard67 - comment - 26 Oct 2019

@Quy Do you wanna make a PR or shall I do it?

avatar Quy
Quy - comment - 26 Oct 2019

Go for it please.

avatar richard67
richard67 - comment - 26 Oct 2019

On the way.

avatar richard67
richard67 - comment - 26 Oct 2019

Done, PR #26829 .

avatar Quy Quy - change - 26 Oct 2019
Status New Closed
Closed_Date 0000-00-00 00:00:00 2019-10-26 12:45:03
Closed_By Quy
avatar Quy Quy - close - 26 Oct 2019
avatar Quy
Quy - comment - 26 Oct 2019

Thank you!

Add a Comment

Login with GitHub to post a comment