Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#26822] - Minor changes on README, CSS & JS

? Pending

User tests: Successful: Unsuccessful:

avatar spahno
spahno
26 Oct 2019

Summary of Changes

TEXT: Added a headline to README.txt
Changed the sub-headline from "What is this?" to "Overview"

JS: Changed the "var" initializers to "let" due to ES6 conventions
replaced '==' with '===' to avoid comparison errors

CSS: Replaced properties safely with 'padding' and added generic default for fonts

Testing Instructions

clone the 4.0-dev branch

avatar spahno spahno - open - 26 Oct 2019
avatar spahno spahno - change - 26 Oct 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Oct 2019
Category ⇒ Repository
avatar brianteeman
brianteeman - comment - 26 Oct 2019

Install the latest beta version of Joomla! (4.0.0)

But the PR is for staging and not the joomla 4 development branch

As for the actual changes in the text - they are not correct

avatar spahno spahno - change - 26 Oct 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 26 Oct 2019
Category Repository ⇒ Repository com_tags Front End
avatar spahno spahno - change - 26 Oct 2019
Title
…
Minor changes on README.md & README.txt
Minor changes on READMEs & template.js
avatar spahno spahno - edited - 26 Oct 2019
avatar spahno spahno - change - 26 Oct 2019
The description was changed
avatar spahno spahno - edited - 26 Oct 2019
avatar spahno spahno - change - 26 Oct 2019
Title
…
Minor changes on READMEs & template.js
Minor changes on READMEs & list_items.php
avatar spahno spahno - edited - 26 Oct 2019
avatar spahno spahno - change - 26 Oct 2019
The description was changed
avatar spahno spahno - edited - 26 Oct 2019
avatar joomla-cms-bot joomla-cms-bot - change - 26 Oct 2019
Category Repository com_tags Front End ⇒ Repository Administration Templates (admin) com_tags Front End
avatar spahno spahno - change - 26 Oct 2019
Title
…
Minor changes on READMEs & list_items.php
Minor changes on README, CSS & JS
avatar spahno spahno - edited - 26 Oct 2019
avatar spahno spahno - change - 26 Oct 2019
The description was changed
avatar spahno spahno - edited - 26 Oct 2019
avatar joomla-cms-bot joomla-cms-bot - change - 26 Oct 2019
Category Repository com_tags Front End Administration Templates (admin) ⇒ Repository Administration Templates (admin) com_tags Front End Templates (site) JavaScript
avatar spahno spahno - change - 26 Oct 2019
The description was changed
avatar spahno spahno - edited - 26 Oct 2019
avatar spahno spahno - change - 26 Oct 2019
The description was changed
avatar spahno spahno - edited - 26 Oct 2019
avatar brianteeman
brianteeman - comment - 26 Oct 2019

Can someone with more patience than me explain to this user why their PR are wrong

avatar HLeithner
HLeithner - comment - 26 Oct 2019

Hi @spahno

thanks for your contribution, but you did several wrong.

  1. your PR is against the wrong branch as brian already mentioned
  2. you are mixing too many different things in one PR (changing readme, updating some, css and introduce es6 code in a branch that have to be ie11 compatible)

I'm closing this pr and please you to create multiple PRs, one for each topic, thx

avatar HLeithner HLeithner - change - 26 Oct 2019
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-10-26 18:34:57
Closed_By ⇒ HLeithner
avatar HLeithner HLeithner - close - 26 Oct 2019
avatar joomla-cms-bot joomla-cms-bot - change - 26 Oct 2019
Category Repository com_tags Front End Administration Templates (admin) Templates (site) JavaScript ⇒ Unit Tests Repository Administration com_admin com_banners com_categories com_config com_contact com_content com_fields com_joomlaupdate com_menus com_messages

Add a Comment

Login with GitHub to post a comment