[#26813] - [4.0] Workflows checked out / checkin
- Fixed in Code Base
- 11 Nov 2019
- Medium
- Build: 4.0-dev
- # 26813
- Diff
- chmst:workflows-checked-out
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Checked_out and Checkin now works in com_workflow in the same way as in all other components
Testing Instructions
Open a workflow or stage or transition, close the browser window. Login again and see the locked icon in list views.
Klick on the locked icon to chckin the item. If you have permission for checkin, the item will be unlocked.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_workflow |
| Title |
|
||||||
| Labels |
Added:
?
|
||
Ah I‘ve forgotten: After following the link, select PHPCS in the list of tests shown at the left hand side to see the PHP code style log.
@richard67 can you help me? The mySql check fails. but I don't see the problem.
@chmst Failure of mysql system test seems to me to be unrelated to this PR. As far as I know they still fail sometimes due to checking things which are not visible yet, e.g. due to CSS transitions. But I am not good in reading those system test logs (the PCPHS is more clear). Maybe someone of the automated testing team can tell? @HLeithner .
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26813.
I have tested this item
Tested with PostgreSQL 10.10 and error reporting = Development and watching database log file and PHP log.
Everything works as expected and there are no errors or warning.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26813.
In addition to the testing instructions, I have also tested that the locked out item is correctly shown on the "Global Check-In" page and the number of locked out items is shown correctly on the system dashboard, and that both checking in with lock icon and on the "Global Check-In" page works.
Null date is also ok.
I have tested this item
#pbf19 #test1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26813.
I have not tested this item.
#pbf19 #test2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26813.
I have tested this item
#pbf19 #test2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26813.
| Status | Pending | ⇒ | Ready to Commit |
| Status | Ready to Commit | ⇒ | Pending |
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26813.
Thanks
| Status | Ready to Commit | ⇒ | Pending |
@richard67 I set the status to Ready To Commit and write RTC in the Issue Tracker. I don't do it in GitHub. Give that a try.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26813.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26813.
PR had enough good tests, changes after that were trivial (names quoting an 4.0 style join syntax for db access). I've tested that and reviewed.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26813.
I have tested this item
Test OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26813.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-11-11 17:10:00 |
| Closed_By | ⇒ | wilsonge |
Thanks!
Please fix PHP code style. These errors are reported by Drone. Just click on link "Details" right beside the "continuous-integration/drone/pr — Build is failing" label at the bottom of this PR in the "Checks" area.