[#2681] - Load the tabs save script only on the edit form
- Closed
- 10 Apr 2014
- Medium
- Build: master
- # 2681
- Diff
- Digital-Peak:tabs
- Foreign ID 32953
- Error This pull request is targeted at the master branch. Pull requests should no longer be merged to master.
User tests: Successful: Unsuccessful:
This PR moves the call to save the state from the content.php bootstrap file to the form view where it belongs to. At the moment it is also useless to have it there because there is no apply function in the front where the state of the tabs needs to be save (check the comment below).
The tracker item http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32953 is already opened.
As stated in the tracker item http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=31372 in the comment from Jean-Marie Simonet
Note: for now it is useless on frontend, but it may one day if we introduce Save (Apply) and correct checkin.
On a sidenote. tabstate doesn't neeed mootools anymore, so the call JHtml::_('script', 'system/tabs-state.js', true, true); in the library is wrong and should be JHtml::_('script', 'system/tabs-state.js', false, true); instead.
| Labels |
Added:
?
|
||
Moved the tabs save code to the form view, where it belongs to.
@Bakual this is already fixed for the next version 0247d9f#diff-f6f264d0b0673dc25ecc75e7746ec235
Can you also test it and update the tracker item. Thanks.
Is there a tracker item for this? The one in the PR description is an old closed one. We need a new one for this.
Updated the description if this PR. Thanks for the hint.
Tested 
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-04-10 13:15:47 |
Actually, it serves a purpose in frontend as well. It will keep the selected tab in the edit form through a page reload, or if you save and re-edit the article.
However the JHtml is definitively wrong in the initial file for com_content. It should be in the edit layout where it's actually needed and where it's able to be overriden. The same is true for in backend btw.
Can you update this PR or create a new one to just move the call to the edit layout instead?