[#26803] - [4.0] Action Logs export
- Fixed in Code Base
- 25 Oct 2019
- Medium
- Build: 4.0-dev
- # 26803
- Diff
- brianteeman:actionlogs
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
This PR makes the column headings of the exported action logs match the column headings as presented on the web
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26803.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26803.
While this is fine in practice, it should be noted in the B/C breaks list because if anyone has any kind of automated tooling expecting the CSV headers in the current format then that will need to be updated (and I say this as someone who writes a fair amount of CSV related export/import tooling (not for this specific feature though) and has code expecting headers in specific formats). The odds of it are pretty much 0 but still figured I'd point it out.
This looks fine - just wondering for something designed to be parsed whether IP Address with the space is ideal because of all the fun parsing spaces. In theory because it's a file and we're exploding over comma's should be fine I guess?
As it is following the standards for a csv file it should be fine
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-25 20:46:52 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
Thanks
Thanks
I have tested this item✅ successfully on 164e9fd
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26803.