Feeling Lucky
Conflicting Files
?
[#26793] - [4.0][Atum][CS] Line-breaks, indents and spaces
- Closed
- 19 Jan 2020
- Medium
- Build: 4.0-dev
- # 26793
- Diff
- ciar4n:atum-cs
- Pending Hound Hound is busy sniffing around... Details
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #26759 .
Summary of Changes
Consistent line-breaks, indents, and spacing across all Atum template SCSS using the following...
"end_with_newline": true,
"indent_char": " ",
"indent_size": 2,
"newline_between_rules": true,
"selector_separator_newline": true,
"space_around_combinator": true,Testing Instructions
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
| Labels |
Added:
?
|
||
ciar4n
- comment
- 24 Nov 2019
Conflicts fixed
Quy
- comment
- 24 Nov 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26793.
wilsonge
- comment
- 18 Jan 2020
Sorry I just came back to this :( shouldn’t have merged the other part first, if you do this and ping me wildly I’ll try and get it merged fast this time :(
ciar4n
- comment
- 19 Jan 2020
If you don't mind, Im gonna close this and create a new pr. Hard negotiating some of these conflicts.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-01-19 12:01:33 |
| Closed_By | ⇒ | ciar4n | |
| Labels |
Added:
Conflicting Files
|
||
wilsonge
- comment
- 21 Jan 2020
Sure. Just ping me when it's in and i'll try and get it in asap
Please fix conflicts.