? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
24 Oct 2019

Pull Request for Issue #26788 .

Summary of Changes

used the query method regexp()

Testing Instructions

Enter some meta keywords in Global Configuration.
Create a banner, enter same meta keywords.
Publish a banner module and enable filtering by meta keywords.

Expected result

Banner not shown.

Actual result

SQL error

Documentation Changes Required

avatar alikon alikon - open - 24 Oct 2019
avatar alikon alikon - change - 24 Oct 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2019
Category Front End com_banners
avatar alikon alikon - change - 24 Oct 2019
Title
use regexp()
[com_banners] use regexp()
avatar alikon alikon - edited - 24 Oct 2019
avatar SharkyKZ
SharkyKZ - comment - 24 Oct 2019

Doesn't work:

42601, 7, ERROR: syntax error at or near "[" LINE 4: ...0 AND cl.own_prefix=0 AND 1) AND (a.metakey ~* [[:<:]]Joo... ^

avatar alikon
alikon - comment - 24 Oct 2019

i'm afraid i've missed to quote [[:<:]] .... was in hurry.....

e2330d6 24 Oct 2019 avatar alikon quote
avatar alikon alikon - change - 24 Oct 2019
Labels Added: ?
avatar SharkyKZ
SharkyKZ - comment - 24 Oct 2019

No difference.

42601, 7, ERROR: syntax error at or near "Joomla" LINE 4: ....own_prefix=0 AND 1) AND (a.metakey ~* '[[:<:]]'Joomla'[[:... ^

avatar SharkyKZ SharkyKZ - test_item - 24 Oct 2019 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 24 Oct 2019

I have tested this item successfully on ed41cd8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26791.

avatar waader
waader - comment - 25 Oct 2019

I tested with postgresql and the nightly build of j39. Following your test instructions I get the following errors:

Warning: Invalid argument supplied for foreach() in joomla39\components\com_banners\models\banners.php on line 208

Warning: Invalid argument supplied for foreach() in joomla39\modules\mod_banners\tmpl\default.php on line 19

avatar alikon
alikon - comment - 1 Nov 2019

closing as the same fix submitted to #26875

avatar alikon alikon - close - 1 Nov 2019
avatar alikon alikon - change - 1 Nov 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-11-01 08:46:04
Closed_By alikon

Add a Comment

Login with GitHub to post a comment