? ? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
24 Oct 2019

Summary of Changes

The class attribute of a quickicon defaults to true.
It will output as 1.
Change it to null so it can be tested if empty.

Testing Instructions

Log in to the back end.
View page source.
Search pulse.
Next to it there is a 1.
Apply PR.
No more 1.

avatar Quy Quy - open - 24 Oct 2019
avatar Quy Quy - change - 24 Oct 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2019
Category Modules Administration
avatar Quy Quy - change - 24 Oct 2019
Title
[4.0] Make quickicon'class attribute default to null
[4.0] Make quickicon's class attribute default to null
avatar Quy Quy - edited - 24 Oct 2019
avatar Quy Quy - change - 24 Oct 2019
The description was changed
avatar Quy Quy - edited - 24 Oct 2019
avatar Quy Quy - change - 24 Oct 2019
The description was changed
avatar Quy Quy - edited - 24 Oct 2019
avatar SharkyKZ SharkyKZ - test_item - 24 Oct 2019 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 24 Oct 2019

I have tested this item successfully on 7e1908f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26786.

avatar uGE70 uGE70 - test_item - 24 Oct 2019 - Tested successfully
avatar uGE70
uGE70 - comment - 24 Oct 2019

I have tested this item successfully on 7e1908f

- Go to backend's dashboard

avatar alikon alikon - change - 24 Oct 2019
Status Pending Ready to Commit
avatar alikon
alikon - comment - 24 Oct 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26786.

avatar wilsonge wilsonge - change - 25 Oct 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-10-25 22:22:20
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 25 Oct 2019
avatar wilsonge wilsonge - merge - 25 Oct 2019
avatar wilsonge
wilsonge - comment - 25 Oct 2019

Thanks!

Add a Comment

Login with GitHub to post a comment