[#26781] - [4.0] [libraries] Add check for real null datetimes to CoreContent table class
- Fixed in Code Base
- 1 Nov 2019
- Medium
- Build: 4.0-dev
- # 26781
- Diff
- richard67:4.0-dev-null-datetimes-core-content
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This is a follow up to recently merged PR's which changed datetime columns in database for real null values.
Because core content (table ucm_content) shall be usable not only for core components', the checks for the old (preudo-)null datetimes are kept and just extended by the check for real null values.
Like for several other components, the table class for core content swaps publish up and down times if they are given and the down time is earlier than the up time. This is not a good thing in my opinion but to change that is outside the scope of this PR.
The check for the condition when to swap is extecned by the check for real null values.
Testing Instructions
Code review should be sufficient: Make sure that in the file modified by this PR there are no other places where old (preudo-)null datetimes are checked without checking for real null values, too.
Expected result
No check of published up and down time for old (preudo-)null datetimes without checking for real null values, too.
Actual result
Check for null values is missing.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26781.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26781.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26781.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-11-01 14:55:24 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
Thanks!
Thanks to all testers and mergers (there are so many of the latter
I have tested this item✅ successfully on d2b0bc8
LGTM
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26781.