? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
22 Oct 2019

Fix the mobile view for the extension updates page by replacing a non-existant class hidden-sm and tweaked which columns to display

For testing you can use the fake extension provided by @nikosdion here http://updates.myoldsite.com/file_null-1.0.zip

Before

image
image

After

image

avatar brianteeman brianteeman - open - 22 Oct 2019
avatar brianteeman brianteeman - change - 22 Oct 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Oct 2019
Category Administration com_installer
avatar alikon alikon - test_item - 22 Oct 2019 - Tested successfully
avatar alikon
alikon - comment - 22 Oct 2019

I have tested this item successfully on d8d284f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26769.

avatar brianteeman
brianteeman - comment - 22 Oct 2019

@wilsonge the drone errors might be valid errors with our build script. I dont have enough access to confirm

avatar Quy Quy - test_item - 22 Oct 2019 - Tested successfully
avatar Quy
Quy - comment - 22 Oct 2019

I have tested this item successfully on d8d284f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26769.

avatar Quy Quy - change - 22 Oct 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 22 Oct 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26769.

avatar dgrammatiko
dgrammatiko - comment - 22 Oct 2019

@brianteeman @wilsonge not the project build tools but the version of node-sass:


Building: /usr/local/bin/node /********/src/node_modules/node-gyp/bin/node-gyp.js rebuild --verbose --libsass_ext= --libsass_cflags= --libsass_ldflags= --libsass_library=
--
24 | gyp info it worked if it ends with ok

.
.
.

42 | gyp verb `which` failed Error: not found: python2

In plain text python is missing

avatar Quy Quy - change - 23 Oct 2019
Labels Added: ?
avatar infograf768 infograf768 - close - 23 Oct 2019
avatar infograf768 infograf768 - merge - 23 Oct 2019
avatar infograf768 infograf768 - change - 23 Oct 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-10-23 06:23:05
Closed_By infograf768
Labels Added: ?
avatar infograf768
infograf768 - comment - 23 Oct 2019

Tks.

avatar brianteeman
brianteeman - comment - 23 Oct 2019

thanks

Add a Comment

Login with GitHub to post a comment