Feeling Lucky
?
?
[#26767] - [4.0][com_banners] fix nowdate double quoted
- Fixed in Code Base
- 23 Oct 2019
- Medium
- Build: 4.0-dev
- # 26767
- Diff
- alikon:patch-112
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #26763 .
Summary of Changes
$nowdate should be quoted once
Testing Instructions
Create a banner and publish the banner module
Expected result
banner shows
Actual result
Warning: Invalid argument supplied for foreach()
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_banners |
richard67
- comment
- 22 Oct 2019
But in principle it could be tested by review, it is clear in code.
waader
- comment
- 22 Oct 2019
I have tested this item
Now it works, thanks alikon!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26767.
richard67
- comment
- 22 Oct 2019
I have tested this item
Finally I could reproduce the banner not showing up. The PHP warnings I did not see, even if error reporting set to Development.
But this PR fixes it, and code review is ok, too.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26767.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 22 Oct 2019
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26767.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-23 02:17:46 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
Hehe, it was not me ;-) It was there before my datetime changes. Am feeling better now. Will test soon.