? ?
avatar ciar4n
ciar4n
22 Oct 2019

Codestyle for indents and line breaks varies across SCSS files within the Atum template. In general, the following standards appear to be followed however there is places where it is not.

"end_with_newline": true,
"indent_char": " ",
"indent_size": 2,
"newline_between_rules": true,
"selector_separator_newline": true,
"space_around_combinator": true,
avatar ciar4n ciar4n - open - 22 Oct 2019
avatar joomla-cms-bot joomla-cms-bot - change - 22 Oct 2019
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 22 Oct 2019
avatar joomla-cms-bot joomla-cms-bot - labeled - 22 Oct 2019
avatar ciar4n ciar4n - change - 22 Oct 2019
The description was changed
avatar ciar4n ciar4n - edited - 22 Oct 2019
avatar ciar4n ciar4n - change - 22 Oct 2019
The description was changed
avatar ciar4n ciar4n - edited - 22 Oct 2019
avatar brianteeman
brianteeman - comment - 22 Oct 2019

shouldn't there be a lint or sniff (I forget the correct term) to test this?

avatar ciar4n
ciar4n - comment - 22 Oct 2019

I believe @C-Lodder had set up hound but it appears to have been disabled. However, if I remember correctly it didn't check line-breaks and indents (I could be wrong on this).

avatar C-Lodder
C-Lodder - comment - 22 Oct 2019

@Hackwar decided to exclude the SCSS files for some reason: #25645

Which explains why the SCSS never gets linted in PRs

avatar Hackwar
Hackwar - comment - 22 Oct 2019

The way I understood the code, it was supposed to be the other way around. If that isn't the case, then I have to apologise and it was an error on my part.

avatar C-Lodder
C-Lodder - comment - 22 Oct 2019

Actually apoligies on my part. It looks like you didn't move them into the exclude flag.

In which case I'm not sure why the SCSS isn't being linted. Could try reverting as a test

avatar ciar4n
ciar4n - comment - 24 Oct 2019

PR.. #26793

Maybe someone could open a separate issue for hound/linting

avatar ciar4n ciar4n - change - 24 Oct 2019
Status New Closed
Closed_Date 0000-00-00 00:00:00 2019-10-24 08:29:35
Closed_By ciar4n
avatar ciar4n ciar4n - close - 24 Oct 2019

Add a Comment

Login with GitHub to post a comment