?
avatar IberoMedia
IberoMedia
13 Dec 2013

file cmsroot/media/jui/js/jquery.js triggers warning "event.returnValue is deprecated. Please use the standard event.preventDefault() instead."

changing line 5374 - 5375

FROM:

this.isDefaultPrevented = ( src.defaultPrevented || src.returnValue === false ||
src.getPreventDefault && src.getPreventDefault() ) ? returnTrue : returnFalse;

TO:

this.isDefaultPrevented = ( src.defaultPrevented || src.getPreventDefault && src.getPreventDefault() ) ? returnTrue : returnFalse;
this.isDefaultPrevented = src.defaultPrevented ? returnTrue : returnFalse;

AS PER OFFICIAL FIX: silverwind/jquery@3d387fb

TRAIL OF THE PULL: jquery/jquery#1294

fixes the warning

avatar IberoMedia IberoMedia - open - 13 Dec 2013
avatar Bakual
Bakual - comment - 13 Dec 2013

I think we have the original jquery.js included in core. If there is a need for a fix, we likely should just update to the lastest release instead of applying fixes ourself.

avatar betweenbrain
betweenbrain - comment - 13 Dec 2013

Yes, we want to avoid modifying any external project's code if possible.

Best,

Matt Thomas
@betweenbrain
http://matt-thomas.me/
http://betweenbrain.com/
https://github.com/betweenbrain

Sent from mobile. Please pardon any typos or brevity.
On Dec 13, 2013 3:32 PM, "Thomas Hunziker" notifications@github.com wrote:

I think we have the original jquery.js included in core. If there is a
need for a fix, we likely should just update to the lastest release instead
of applying fixes ourself.


Reply to this email directly or view it on GitHub#2675 (comment)
.

avatar betweenbrain
betweenbrain - comment - 13 Dec 2013

As it is only a deprecation warning, I wouldn't be too concerned with it.

Best,

Matt Thomas
@betweenbrain
http://matt-thomas.me/
http://betweenbrain.com/
https://github.com/betweenbrain

Sent from mobile. Please pardon any typos or brevity.
On Dec 13, 2013 5:01 AM, "IberoMedia" notifications@github.com wrote:

file cmsroot/meida/jui/js/jquery.js triggers warning "event.returnValue is
deprecated. Please use the standard event.preventDefault() instead."

changing line 5374 - 5375

FROM:

this.isDefaultPrevented = ( src.defaultPrevented || src.returnValue ===
false ||
src.getPreventDefault && src.getPreventDefault() ) ? returnTrue :
returnFalse;

TO:

this.isDefaultPrevented = ( src.defaultPrevented || src.preventDefault()=== false ||
src.getPreventDefault && src.getPreventDefault() ) ? returnTrue :
returnFalse;

fixes the warning


Reply to this email directly or view it on GitHub#2675
.

avatar zero-24 zero-24 - close - 27 Aug 2014
avatar brianteeman
brianteeman - comment - 27 Aug 2014

Closing based on the comments above

avatar brianteeman brianteeman - change - 27 Aug 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-08-27 10:15:56
avatar brianteeman brianteeman - close - 27 Aug 2014
avatar zero-24 zero-24 - change - 7 Jul 2015
Labels Added: ?

Add a Comment

Login with GitHub to post a comment