Joomla! Issue Tracker | Joomla! CMS #26747 - Fields

? ? ?

Fixed in Code Base
9 Dec 2019
Medium
Build: staging
# 26747
Diff
brianteeman:fields

Pending

Pending Hound Hound is busy sniffing around... Details

User tests: Successful: Unsuccessful:

brianteeman
20 Oct 2019

If you want to search in the list of fields to find a specific field then there is more that you can do that simply search in the title. But there is no way to know this without reading the code.

This PR adds the full information for searching for a field or field group as a tooltip. This is in exactly the same format as in other components.

This PR also alpha sorts the language file

If you want to check the search code you can find it

joomla-cms/administrator/components/com_fields/models/fields.php

Lines 276 to 295 in 25ba7e5

    
           		// Filter by search in title 
        
           		$search = $this->getState('filter.search'); 
        
           		if (! empty($search)) 
        
           		{ 
        
           			if (stripos($search, 'id:') === 0) 
        
           			{ 
        
           				$query->where('a.id = ' . (int) substr($search, 3)); 
        
           			} 
        
           			elseif (stripos($search, 'author:') === 0) 
        
           			{ 
        
           				$search = $db->quote('%' . $db->escape(substr($search, 7), true) . '%'); 
        
           				$query->where('(ua.name LIKE ' . $search . ' OR ua.username LIKE ' . $search . ')'); 
        
           			} 
        
           			else 
        
           			{ 
        
           				$search = $db->quote('%' . str_replace(' ', '%', $db->escape(trim($search), true) . '%')); 
        
           				$query->where('(a.title LIKE ' . $search . ' OR a.name LIKE ' . $search . ' OR a.note LIKE ' . $search . ')'); 
        
           			} 
        
           		}

joomla-cms/administrator/components/com_fields/models/groups.php

Lines 180 to 192 in 25ba7e5

    
           		// Filter by search in title 
        
           		$search = $this->getState('filter.search'); 
        
           		if (!empty($search)) 
        
           		{ 
        
           			if (stripos($search, 'id:') === 0) 
        
           			{ 
        
           				$query->where('a.id = ' . (int) substr($search, 3)); 
        
           			} 
        
           			else 
        
           			{ 
        
           				$search = $db->quote('%' . str_replace(' ', '%', $db->escape(trim($search), true) . '%')); 
        
           				$query->where('a.title LIKE ' . $search);

ce5de77 20 Oct 2019

fields search - hidden secret

5cc5bb9 20 Oct 2019

groups

brianteeman - open - 20 Oct 2019

brianteeman - change - 20 Oct 2019

Status

New

⇒

Pending

joomla-cms-bot - change - 20 Oct 2019

Category

⇒

Administration com_fields Language & Strings

brianteeman - comment - 20 Oct 2019

@zero-24 @SniperSister please can you look at the rips error

SniperSister - comment - 21 Oct 2019

@brianteeman the drone.yml in your branch is outdated and incompatible to the new RIPS version that we are using. Updating the yaml (or updating the branch in general) will solve the issue.

1ebb4a6 21 Oct 2019

Merge branch 'staging' into fields

brianteeman - change - 21 Oct 2019

Labels

Added: ? ?

brianteeman - comment - 21 Oct 2019

Thanks

brianteeman - comment - 21 Oct 2019

grrh - now it fails on some javascript that is unrelated to anything in this pr

infograf768 - comment - 21 Oct 2019

relaunched drone

50d0598 9 Nov 2019

Merge branch 'staging' into fields

brianteeman - change - 6 Dec 2019

Status	Pending	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2019-12-06 23:07:07
Closed_By		⇒	brianteeman

brianteeman - close - 6 Dec 2019

brianteeman - change - 6 Dec 2019

Status	Closed	⇒	New
Closed_Date	2019-12-06 23:07:07	⇒
Closed_By	brianteeman	⇒

brianteeman - change - 6 Dec 2019

Status

New

⇒

Pending

brianteeman - reopen - 6 Dec 2019

f9e90d6 6 Dec 2019

Update administrator/language/en-GB/en-GB.com_fields.ini

Quy - test_item - 7 Dec 2019 - Tested successfully

Quy - comment - 7 Dec 2019

I have tested this item ✅ successfully on f9e90d6

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26747.}

viocassel - test_item - 7 Dec 2019 - Tested successfully

viocassel - comment - 7 Dec 2019

I have tested this item ✅ successfully on f9e90d6

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26747.}

Quy - change - 7 Dec 2019

Status

Pending

⇒

Ready to Commit

Quy - comment - 7 Dec 2019

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26747.}

HLeithner - change - 9 Dec 2019

Status	Ready to Commit	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2019-12-09 10:03:38
Closed_By		⇒	HLeithner
Labels	Added: ?

HLeithner - close - 9 Dec 2019

HLeithner - merge - 9 Dec 2019

HLeithner - comment - 9 Dec 2019

Thanks

brianteeman - comment - 9 Dec 2019

Thanks

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#26747] - Fields - hidden secrets

Add a Comment

	// Filter by search in title
	$search = $this->getState('filter.search');

	if (! empty($search))
	{
	if (stripos($search, 'id:') === 0)
	{
	$query->where('a.id = ' . (int) substr($search, 3));
	}
	elseif (stripos($search, 'author:') === 0)
	{
	$search = $db->quote('%' . $db->escape(substr($search, 7), true) . '%');
	$query->where('(ua.name LIKE ' . $search . ' OR ua.username LIKE ' . $search . ')');
	}
	else
	{
	$search = $db->quote('%' . str_replace(' ', '%', $db->escape(trim($search), true) . '%'));
	$query->where('(a.title LIKE ' . $search . ' OR a.name LIKE ' . $search . ' OR a.note LIKE ' . $search . ')');
	}
	}

	// Filter by search in title
	$search = $this->getState('filter.search');

	if (!empty($search))
	{
	if (stripos($search, 'id:') === 0)
	{
	$query->where('a.id = ' . (int) substr($search, 3));
	}
	else
	{
	$search = $db->quote('%' . str_replace(' ', '%', $db->escape(trim($search), true) . '%'));
	$query->where('a.title LIKE ' . $search);