?
avatar brianteeman
brianteeman
20 Oct 2019

As seen in the screenshots below some recent changes have messed up the display

Quickicons

  • Image not centered
  • Text too close to image

image

Add module

  • Image not contained in the box
    image

Add item

  • Icon not contained in box
    image
avatar brianteeman brianteeman - open - 20 Oct 2019
avatar joomla-cms-bot joomla-cms-bot - change - 20 Oct 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 20 Oct 2019
avatar brianteeman brianteeman - change - 20 Oct 2019
The description was changed
avatar brianteeman brianteeman - edited - 20 Oct 2019
avatar Quy
Quy - comment - 20 Oct 2019

PR #26056 is the culprit.

avatar infograf768
infograf768 - comment - 21 Oct 2019

I can solve the icon not contained in box in my RTL patch to come as the error is also present there and does not need a specific rtl override.
I can also solve the position of the add Module icon in the same PR.

The other stuff is a bit more complex.
Text too close to image is in fact due to multiple lines and depends on the window width as the width of the quickicon container changes and not the height...
Centering of the icons themselves is also a bit tricky as we have to differentiate between quickicons icons with a + sign in <li> with quickicon-linkadd class an the others.

avatar infograf768
infograf768 - comment - 21 Oct 2019

@Quy
Reverting #26056 solves all indeed (in LTR) except the centering of the Dashboard Add Module icon.
We can solve this last one with

.com_cpanel .cpanel-add-module .cpanel-add-module-icon {
    position: absolute;
    top: -0.25rem;  //instead of 0
    left: 12rem;  // instead of 0
    right: 0;
    bottom: 0;
}

Screen Shot 2019-10-21 at 09 23 09

avatar Quy
Quy - comment - 22 Oct 2019

Revert the PR.

In \libraries\src\Toolbar\Button\PopupButton.php, change fa fa-square to icon-square. The other icons use icon- except for the Batch icon.

avatar infograf768
infograf768 - comment - 22 Oct 2019

Doing that now. Will also correct the Dashboard add module stuff at the same time.

avatar infograf768
infograf768 - comment - 22 Oct 2019

Please test #26757

avatar infograf768 infograf768 - change - 22 Oct 2019
Status New Closed
Closed_Date 0000-00-00 00:00:00 2019-10-22 06:20:45
Closed_By infograf768
avatar infograf768 infograf768 - close - 22 Oct 2019

Add a Comment

Login with GitHub to post a comment