? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
19 Oct 2019

Pull Request for Issue "popstgresql and mysql 8 system test fail since #25090 has been merged" .

Summary of Changes

See the diff: With the changes of PR #25090 , the group by was missing in the 2nd changed statement. The join syntax of the 1st statement I change to the one used in the 2nd statement for consistenty and because that's the new J4 way to do it.

Testing Instructions

Code review, or install a clean 4.0-dev on Postgresql and then try to create a user.

Expected result

All ok.

Actual result

Unbenannt

Documentation Changes Required

None.

avatar richard67 richard67 - open - 19 Oct 2019
avatar richard67 richard67 - change - 19 Oct 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Oct 2019
Category Administration com_users
avatar richard67 richard67 - change - 19 Oct 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 19 Oct 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-10-19 17:42:07
Closed_By wilsonge
avatar wilsonge wilsonge - close - 19 Oct 2019
avatar wilsonge wilsonge - merge - 19 Oct 2019
avatar wilsonge
wilsonge - comment - 19 Oct 2019

System tests passing for mysql8 and postgres which they weren't before. Good enough for me :)

Thankyou!

avatar richard67
richard67 - comment - 19 Oct 2019

Have tested with real test and it worked, too.

Add a Comment

Login with GitHub to post a comment