Feeling Lucky
?
?
[#26720] - [4.0] Heading is missing on "Template Preview" Popup
- Fixed in Code Base
- 19 Oct 2019
- Medium
- Build: 4.0-dev
- # 26720
- Diff
- wilsonge:bugfix/missing-preview-title
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #26691 .
Summary of Changes
Uses new style syntax for the template preview button which correctly sets the title in the the popup modal
Testing Instructions
Open the template preview modal. Before the patch there is a missing title (see image in the original issue). After patch the title now shows and the close button is correctly spaced
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates |
| Labels |
Added:
?
|
||
Quy
- comment
- 19 Oct 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26720.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 19 Oct 2019
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26720.
richard67
- comment
- 19 Oct 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26720.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-19 21:05:44 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 19 Oct 2019
Thanks guys!
I have tested this item✅ successfully on 074c694
I see the header. Probably an extra point for accessibility. Although I did hear popups cannot be accessible because of screen readers or something. I'm no expert.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26720.