[#26681] - [4.0] Feature: Article > Save To Menu
- Fixed in Code Base
- 2 Nov 2019
- Medium
- Build: 4.0-dev
- # 26681
- Diff
- Didldu-Florian:articlesave2menu
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue from facebook
https://www.facebook.com/groups/joomla.deutschland/permalink/1346440042196465/
Summary of Changes
Save a content directy to a new menu item.
PR requires #26675
Update: Removes also the old useless "add menu item" button.
Testing Instructions
- Apply Patch #26675 (required)
- Apply these Partch
- Create a new article
- Click on "Save to menu"
- Article should been saved and redirects you to com_menu
- Menu SingleArticle should been preselected with the article you've created and the title from the article
Expected result
Actual result
New Feature
Documentation Changes Required
Yes, maybe
PR for the user survey from facebook + 50 users voted
Additional Infos
It's a global Save2Menu Function, could be finaly implement in any component
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content Language & Strings |
It's a global Save2Menu Function, could be finaly implement in any component
| Labels |
Added:
?
?
|
||
I have tested this item
When I apply the patch there is this message :
Warning: require(D:\xampp2\htdocs\pizza\libraries\vendor\composer/../hoa/consistency/Prelude.php): failed to open stream: No such file or directory in D:\xampp2\htdocs\pizza\libraries\vendor\composer\autoload_real.php on line 66
Fatal error: require(): Failed opening required 'D:\xampp2\htdocs\pizza\libraries\vendor\composer/../hoa/consistency/Prelude.php' (include_path='D:\xampp2\php\PEAR') in D:\xampp2\htdocs\pizza\libraries\vendor\composer\autoload_real.php on line 66
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26681.
I have tested this item
When I apply the patch there is this message :
Warning: require(D:\xampp2\htdocs\pizza\libraries\vendor\composer/../hoa/consistency/Prelude.php): failed to open stream: No such file or directory in D:\xampp2\htdocs\pizza\libraries\vendor\composer\autoload_real.php on line 66
Fatal error: require(): Failed opening required 'D:\xampp2\htdocs\pizza\libraries\vendor\composer/../hoa/consistency/Prelude.php' (include_path='D:\xampp2\php\PEAR') in D:\xampp2\htdocs\pizza\libraries\vendor\composer\autoload_real.php on line 66
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26681.
When I apply the patch there is this message
Warning: require(D:\xampp2\htdocs\pizza\libraries\vendor\composer/../hoa/consistency/Prelude.php): failed to open stream: No such file or directory in D:\xampp2\htdocs\pizza\libraries\vendor\composer\autoload_real.php on line 66
Fatal error: require(): Failed opening required 'D:\xampp2\htdocs\pizza\libraries\vendor\composer/../hoa/consistency/Prelude.php' (include_path='D:\xampp2\php\PEAR') in D:\xampp2\htdocs\pizza\libraries\vendor\composer\autoload_real.php on line 66
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26681.
Quy
- | Title |
|
||||||
When I apply the patch there is this message
Warning: require(D:\xampp2\htdocs\pizza\libraries\vendor\composer/../hoa/consistency/Prelude.php): failed to open stream: No such file or directory in D:\xampp2\htdocs\pizza\libraries\vendor\composer\autoload_real.php on line 66
Fatal error: require(): Failed opening required 'D:\xampp2\htdocs\pizza\libraries\vendor\composer/../hoa/consistency/Prelude.php' (include_path='D:\xampp2\php\PEAR') in D:\xampp2\htdocs\pizza\libraries\vendor\composer\autoload_real.php on line 66
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26681.
Your Error has nothing to do with the patch
| Category | Administration com_content Language & Strings | ⇒ | Administration com_content Language & Strings Libraries |
I have tested this item
good feature
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26681.
I have tested this item
Yes! Nice.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26681.
This feature is already present
I have tested this item
The following error message appaers by installaing the requested pr #26675 ( ! ) Warning: require(C:\wamp\www\joomla\libraries\vendor\composer/../hoa/consistency/Prelude.php): failed to open stream: No such file or directory in C:\wamp\www\joomla\libraries\vendor\composer\autoload_real.php on line 66
I've installad Joomla_4.0.0-beta1-dev-Development-Full_Package nightly build and
https://github.com/joomla-extensions/patchtester/releases/tag/4.0.0-beta2
So the same error as mentioned before.
Note: The autoload_real.php on line 66 seems an issue because other "pizza bug & fun attendees" have the save issue in Nijmegen (with other issues).
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26681.
@brianteeman only in edit an exisiting and not with passing data
Maybe but this is not the solution as we now have two completely different "save to menu" type buttons with completely different styling and different code
@Didldu-Florian I was guessing that as answer indeed. However, it might be a bit confusing now, as the behaviour is now different for the same action (creating menu item) depending on if your article is saved (modal) or not yet (redirect). Can't we make the behaviour similar to both cases?
I would also make more sense to add it to the "Save & Close" dropdown, so "Save & Create menu" or something?
Yes, let me merge these in these PR, because the current feature is not helpful. It opens just the menu creatin in a modal and did not pass any data. Maybe we can use the button including my function. Will try to merge it.
@brianteeman did also removed the old add menu button
I have tested this item
It's fine
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26681.
So we are waiting for new code to test again?
I have tested this item
Test OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26681.
Sorry for late response. But this is not ready yet. Please remove this code, it was used by menu modal button
joomla-cms/administrator/components/com_content/View/Article/HtmlView.php
Lines 211 to 234 in 823e9c9
An observation - with the way workflows is setup now by default when you create an article it is in the unpublished state. So when you create a new article and save to menu the menu will 404 because the article it is linking to is not published yet
Can we go RTC ?
This needs tests again after last code changes.
One thing I just noticed is that because the default behaviour of a new article is for it to be unpublished on save if you "save to menu" then it will appear to not work on the frontend because the article is not published
@Didldu-Florian I'll test when I have time, if you don't hear in a few days feel free to prompt me.
I have tested this item
#jpbf19 #test1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26681.
I have tested this item
I have tested this Patch. It works!
This is simple & sweet feature.
#pbf19 #test2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26681.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26681.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-11-02 23:49:07 |
| Closed_By | ⇒ | wilsonge |
Thanks!
I have tested this item✅ successfully on 7a5d0c0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26681.