[#26675] - [4.0] Fixed lost request parameters on save
- Fixed in Code Base
- 6 Dec 2019
- Medium
- Build: 4.0-dev
- # 26675
- Diff
- Didldu-Florian:patch-1
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26675.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26675.
If I checked the history correctly this code exists since 10+ years. Why does it fail now and does it impact any other component?
It fails in 3.x too. My guess the idea here is not to send request to the model because request doesn't exist in the table and is not stored by the model.
If you want, this can be refactored so request is still stored to user state but not sent to the model.
@HLeithner it shouldn't effect, it's an old bug and these PR is also required for the already merged Save2Menu Feature #26681 ! If it couldn't be merged, we could also not go with the merged PR #26681
The shouldn't be any problem that this parameter get's to the model, JTable wouldn't save it if the field doesn't exists.
The only question is, are there any site effects for any component if this exists now? I don't think so but maybe I'm missing something.
Yes, but we did fixed that, because it is definetly required for #26681 to pass the data from the article. Without that PR, #26681 will definetly not run. At the PBF we had tested it also with other components. Unfortunately I cannot answer myself whether it has an effect on any other components. But it couldn't be a huge problem.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-12-06 08:21:28 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thanks.
Thanks.
I have tested this item✅ successfully on 08f6579
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26675.