Feeling Lucky
?
[#2667] - [#32937] Get media from module folder
- Closed
- 11 Dec 2013
- Medium
- Build: master
- # 2667
- Diff
- brunowego:patch-22
- Foreign ID 32937
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
I really love build extension in originally extension folder. Like language where if the language exists in extension folder, joomla by default load the file. I believe this feature can happen for media folder too.
Pull Request: #32937
Bakual
- comment
- 11 Dec 2013
I don't understand. Are you trying to override files using a module? Or what is the use case?
brunobatista
- comment
- 11 Dec 2013
When I build extensions for distribute or for my projects, I try create all files inside the module folder for easy compact after finish. This feature will help me to build more fast extensions.
| Title |
|
||||||
| Description | <p>I really love build extension in originally extension folder. Like language where if the language exists in extension folder, joomla by default load the file. I believe this feature can happen for media folder too.</p> | ⇒ | <p>I really love build extension in originally extension folder. Like language where if the language exists in extension folder, joomla by default load the file. I believe this feature can happen for media folder too.</p> <p>Pull Request: #32937</p> <p><a href="http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32937&start=0">http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32937&start=0</a></p> | ||||
| Status | New | ⇒ | Closed | ||||
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2013-12-11 14:02:08 | ||||
| Labels |
Added:
?
|
||||||
I can get on board with the concept, but where you've done this isn't right. The method you patched is handling generically media loading based on the media folder with templates able to override; it doesn't have extension type specific handling. And, if we're going to do this for modules, it might as well be done for components too, but I don't think this specific method is the place to do it simply because it is a high level abstraction.