Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#26631] - [4.0] Change file icon

? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
18 Oct 2019

Pull Request for Issue #25915.

Summary of Changes

Make folder and file icons more distinguishable.

Testing Instructions

Go System > Site Templates > Cassiopeia Details and Files

Expected result

25915

Actual result

63211700-c0285c80-c0f2-11e9-92c2-2c546aba878c

avatar Quy Quy - open - 18 Oct 2019
avatar Quy Quy - change - 18 Oct 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Oct 2019
Category ⇒ Administration com_templates
avatar brianteeman
brianteeman - comment - 18 Oct 2019

For consistency can you check to see if you need to make the same change in
administrator\components\com_templates\tmpl\template\default.php
plugins\quickicon\overridecheck\overridecheck.php

avatar Quy
Quy - comment - 19 Oct 2019

Probably keep it as it to not match the Articles icon.

override

or change to the following to match under the Create Override tab.

override-copy

avatar infograf768
infograf768 - comment - 19 Oct 2019

Mayve we should upgrade from version 5.9.0 to 5.11.2 where we do have, with the prefix far a nice file icon outlined

See https://fontawesome.com/icons/file?style=regular

avatar uthorat uthorat - test_item - 19 Oct 2019 - Tested successfully
avatar uthorat
uthorat - comment - 19 Oct 2019

I have tested this item ✅ successfully on 806a536

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26631.

avatar pallaviu pallaviu - test_item - 19 Oct 2019 - Tested successfully
avatar pallaviu
pallaviu - comment - 19 Oct 2019

I have tested this item ✅ successfully on 806a536

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26631.

avatar priyankaSahutekdi priyankaSahutekdi - test_item - 19 Oct 2019 - Tested successfully
avatar priyankaSahutekdi
priyankaSahutekdi - comment - 19 Oct 2019

I have tested this item ✅ successfully on 806a536

Woring successfully

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26631.

avatar Ekta29yadav Ekta29yadav - test_item - 19 Oct 2019 - Tested successfully
avatar Ekta29yadav
Ekta29yadav - comment - 19 Oct 2019

I have tested this item ✅ successfully on 806a536

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26631.

avatar idefax idefax - test_item - 19 Oct 2019 - Tested successfully
avatar idefax
idefax - comment - 19 Oct 2019

I have tested this item ✅ successfully on 806a536

Works fine.

I used:

PHP Version 7.3.8
Web Server Apache
WebServer to PHP Interface cgi-fcgi
Joomla! Version Joomla! 4.0.0-beta1-dev Development [ Amani ] 17-October-2019 20:21 GMT
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26631.

avatar HLeithner HLeithner - change - 19 Oct 2019
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-10-19 09:02:20
Closed_By ⇒ HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 19 Oct 2019
avatar HLeithner HLeithner - merge - 19 Oct 2019
avatar HLeithner
HLeithner - comment - 19 Oct 2019

Thanks for all the tests.

#pbf19

avatar Quy
Quy - comment - 19 Oct 2019

@infograf768 If/when FA is upgraded, I will submit another PR.

avatar Scrabble96
Scrabble96 - comment - 19 Oct 2019

As in my original issue #25915, could you use the reverse icon? It's now available in 5.11.2 and would make the icons even more distinguishable:

fontawesome-5 11 2_file-alt-regular

avatar ttplpoojak ttplpoojak - test_item - 19 Oct 2019 - Tested successfully
avatar ttplpoojak
ttplpoojak - comment - 19 Oct 2019

I have tested this item ✅ successfully on 806a536

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26631.

Add a Comment

Login with GitHub to post a comment