? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
17 Oct 2019

Summary of Changes

Adding specific RTL css to Atum

Testing Instructions

Install a new site and add Persian language (fa-IR).
Load administrator/index.php?option=com_languages&view=installed&client=1 (admin languages)
Switch to Persian.

Reduce browser window width as shown below, click on the Header More Icon (Ellipsis icon) to display the various modules in the Status position as they are hidden when the window is reduced.

To patch, one has to use npm !!!

Before patch

badheader

After patch

goodheader

Note

There are many other aspects of RTL to be taken care of when reducing the window width.

avatar infograf768 infograf768 - open - 17 Oct 2019
avatar infograf768 infograf768 - change - 17 Oct 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Oct 2019
Category Administration Templates (admin)
avatar infograf768 infograf768 - change - 17 Oct 2019
Labels Added: NPM Resource Changed ?
avatar infograf768 infograf768 - change - 18 Oct 2019
Labels Removed: NPM Resource Changed
avatar vaibhavsTekdi vaibhavsTekdi - test_item - 19 Oct 2019 - Tested unsuccessfully
avatar vaibhavsTekdi
vaibhavsTekdi - comment - 19 Oct 2019

I have tested this item 🔴 unsuccessfully on 9d10b05

Tested this with the patch but it's not working as per expectations. Placement is working but the toggle is not working for multilingual site.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26613.

avatar pallaviu pallaviu - test_item - 19 Oct 2019 - Tested unsuccessfully
avatar pallaviu
pallaviu - comment - 19 Oct 2019

I have tested this item 🔴 unsuccessfully on 9d10b05

Menu placement in multilingual is correct but toggle is not working as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26613.

avatar infograf768
infograf768 - comment - 19 Oct 2019

This patch needs using npm to create the correct css.

avatar infograf768 infograf768 - change - 19 Oct 2019
The description was changed
avatar infograf768 infograf768 - edited - 19 Oct 2019
avatar infograf768
infograf768 - comment - 19 Oct 2019

@pallaviu @vaibhavsTekdi

Are you testing with patchtester or from a github clone and composer/npm ?

You need the later to test.

avatar sanderpotjer sanderpotjer - test_item - 19 Oct 2019 - Tested successfully
avatar sanderpotjer
sanderpotjer - comment - 19 Oct 2019

I have tested this item ✅ successfully on 44809c0

After npm the mentioned RTL issues are fixed.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26613.

avatar wilsonge wilsonge - change - 19 Oct 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-10-19 14:12:15
Closed_By wilsonge
avatar wilsonge wilsonge - close - 19 Oct 2019
avatar wilsonge wilsonge - merge - 19 Oct 2019
avatar wilsonge
wilsonge - comment - 19 Oct 2019

Thanks!

Add a Comment

Login with GitHub to post a comment