?
avatar brianteeman
brianteeman
15 Oct 2019

Most of the options fieldsets have a css class of .options-grid-form-full which assuming i read this correctly means that they should be in one column.


.options-grid-form.options-grid-form-full > div {
      grid-template-columns: 1fr;
]

However as can be seen below they are in two uneven columns
image

The cause of this is the description div which is set to start at col 1 and end at col 3 eben though at this resolution there is only 1 column.

.com_config .tab-description {
    grid-column: 1/3;
} 

This should be set to either grid-column:auto or removed as auto is the default and then we have one column displayed as per the defined css.

I could do this but I am not sure if it was intended to be in two columns or not.

(As noted elsewhere by @C-Lodder two columns horizontally is not aa good idea)

avatar brianteeman brianteeman - open - 15 Oct 2019
avatar joomla-cms-bot joomla-cms-bot - change - 15 Oct 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 15 Oct 2019
avatar ciar4n
ciar4n - comment - 16 Oct 2019

Is there anywhere the tab-description is not inside options-grid-form-full? The CSS itself implies that there is. If so your suggested change will affect them.

Using grid-column: 1/3; inside a single column grid creates an implicit grid with 3 columns which is what's happening here. Considering this issue, I can only presume this wasn't intended.

avatar brianteeman
brianteeman - comment - 16 Oct 2019

Is there anywhere the tab-description is not inside options-grid-form-full?

yes there are some

avatar ciar4n
ciar4n - comment - 16 Oct 2019

Change to this instead...

.com_config .tab-description {
    grid-column: 1 / -1;
} 

.tab-description will be full width regardless of the number of columns and not effect the grid.

avatar Quy Quy - close - 16 Oct 2019
avatar Quy Quy - change - 16 Oct 2019
Status New Closed
Closed_Date 0000-00-00 00:00:00 2019-10-16 19:09:13
Closed_By Quy
avatar Quy
Quy - comment - 16 Oct 2019

See PR #26608


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26605.

Add a Comment

Login with GitHub to post a comment