Feeling Lucky
?
?
[#26603] - fix issue in com_joomlaupdate cc @hleinthner
- Fixed in Code Base
- 16 Oct 2019
- Medium
- Build: 3.10-dev
- # 26603
- Diff
- zero-24:fixMergeConflict
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #26587
Summary of Changes
Add missing opening ( after the merge conflict.
Testing Instructions
apply the patch notice is gone and the updater page shows up
Expected result
notice is gone and the updater page shows up
Actual result
syntax error, unexpected '||' (T_BOOLEAN_OR)
Documentation Changes Required
none
cc @hleinthner
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
SharkyKZ
- comment
- 15 Oct 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26603.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
SharkyKZ
- comment
- 15 Oct 2019
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26603.
SharkyKZ
- comment
- 15 Oct 2019
Sorry, the bot removed milestone and it won't let me add it back
richard67
- comment
- 16 Oct 2019
@HLeithner Just to ping you with the right spelling
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-16 06:51:58 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
HLeithner
- comment
- 16 Oct 2019
Thanks for fixing this.
I have tested this item✅ successfully on 6d61e1f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26603.