[#26598] - 4.0 dev Clean up code deprecated code array()
- Closed
- 15 Oct 2019
- Medium
- Build: staging
- # 26598
- Diff
- joomla:4.0-dev
- Success continuous-integration/appveyor/branch AppVeyor build succeeded Details
- Success continuous-integration/drone/push Build is passing Details
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
@wilsonge @brianteeman
According to php.net https://secure.php.net/manual/en/migration70.incompatible.php in PHP7 array() it is deprecated and replaced by [], so I set out to find all the array() Joomla_4.0.0-alpha12-dev-Development-Full_Package.zip and found More than 2500 that I replaced with [], I did it through Dreamweaver distinguishing between upper and lower case letters as well as avoiding the blank spaces, I proceeded to install and definitely feel the lightest system, without problems. I can provide the file for either the full or update version for either 3.9.12 or 4.x
In your case, any of you can do it on your own is a quick process on a good computer but especially with SSD since otherwise it would be slow and with possible failures.
It is very important to do this code cleaning and updating, in this way it is even more reliable and safe than making to hand the more than 2500 changes in more than 5000 files that gave me the result.
So keep the best Joomla CMS updated and error free.
Summary of Changes
Change array() to []
Testing Instructions
Expected result
Work as usual or better
Actual result
Deprecated code
Documentation Changes Required
After the changes everything works
| Status | New | ⇒ | Pending |
| Category | ⇒ | Unit Tests Repository Administration |
| Closed_Date | 2019-10-15 05:38:44 | ⇒ | 2019-10-15 05:38:45 |
| Closed_By | SharkyKZ | ⇒ | joomla-cms-bot |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-15 05:38:44 |
| Closed_By | ⇒ | SharkyKZ |
Set to "closed" on behalf of @SharkyKZ by The JTracker Application at issues.joomla.org/joomla-cms/26598
You're trying to merge one branch of this repository into another branch. To make your changes you first have to clone the repository, create a branch in your new repository for this PR, make your changes in that branch and then submit it against an appropriate branch in this repository. See this guide https://docs.joomla.org/My_first_pull_request_to_Joomla!_on_Github.
I advise not to waste time on replacing existing array syntax. There are automated tools like PHP CS Fixer that can do this.