? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
14 Oct 2019

The class used in com_workflows (hidden-sm-down) was removed from bs between bs4 alpha and the final release

This PR correctly changes the class used to d-none d-md-table-cell

Testing Instructions

Make sure the relevant columns are not displayed in mobile views

avatar brianteeman brianteeman - open - 14 Oct 2019
avatar brianteeman brianteeman - change - 14 Oct 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Oct 2019
Category Administration com_workflow
avatar brianteeman brianteeman - change - 14 Oct 2019
Labels Added: ?
avatar Quy Quy - test_item - 14 Oct 2019 - Tested successfully
avatar Quy
Quy - comment - 14 Oct 2019

I have tested this item successfully on 577de9e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26592.

avatar priyankaSahutekdi priyankaSahutekdi - test_item - 19 Oct 2019 - Tested successfully
avatar priyankaSahutekdi
priyankaSahutekdi - comment - 19 Oct 2019

I have tested this item successfully on 577de9e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26592.

avatar punambaravkar punambaravkar - test_item - 19 Oct 2019 - Tested successfully
avatar punambaravkar
punambaravkar - comment - 19 Oct 2019

I have tested this item successfully on 577de9e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26592.

avatar Quy Quy - change - 19 Oct 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 19 Oct 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26592.

avatar wilsonge
wilsonge - comment - 19 Oct 2019

Conflicts please

avatar brianteeman
brianteeman - comment - 19 Oct 2019

@wilsonge where was the class "order" added

avatar wilsonge
wilsonge - comment - 19 Oct 2019

It wasn't? You removed it as it was unused I believe

avatar wilsonge
wilsonge - comment - 19 Oct 2019

#26593 This PR

avatar brianteeman brianteeman - change - 19 Oct 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 19 Oct 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-10-19 13:29:42
Closed_By wilsonge
avatar wilsonge wilsonge - close - 19 Oct 2019
avatar wilsonge wilsonge - merge - 19 Oct 2019
avatar wilsonge
wilsonge - comment - 19 Oct 2019

Thanks!

avatar brianteeman
brianteeman - comment - 19 Oct 2019

Thanks

Add a Comment

Login with GitHub to post a comment