? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
13 Oct 2019

Pull Request for Issue # .

Summary of Changes

Follow up to PR #26295 , which introduced real NULL values for datetime columns in com_content's database table.

Extends the range filter for datetimes in the articles model (frontend) so that

  1. One of the parameters start and end of the range may be ommitted.
  2. The date to be filtered might be a real NULL value. The filter query will handle that.

Testing Instructions

Code review, or use that datetime filtering of the frontend articles model somewhere.

Expected result

See summary of changes.

Actual result

None of that.

Documentation Changes Required

None as far as I can see.

avatar richard67 richard67 - open - 13 Oct 2019
avatar richard67 richard67 - change - 13 Oct 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Oct 2019
Category Front End com_content
1149bc4 13 Oct 2019 avatar richard67 PHPCS
avatar richard67 richard67 - change - 13 Oct 2019
Labels Added: ?
avatar richard67 richard67 - change - 13 Oct 2019
Title
[4.0] More flexible datetime range filter in articles model
[4.0] [WiP] More flexible and null value aware datetime range filter in articles model
avatar richard67 richard67 - edited - 13 Oct 2019
avatar richard67
richard67 - comment - 13 Oct 2019

@wilsonge Does it need to write testing instructions? Those are the only reason why it is still draft/WiP. I can write tomorrow if necessary. Or would "code review" be enough?

avatar richard67 richard67 - change - 13 Oct 2019
The description was changed
avatar richard67 richard67 - edited - 13 Oct 2019
avatar richard67 richard67 - change - 13 Oct 2019
Title
[4.0] [WiP] More flexible and null value aware datetime range filter in articles model
[4.0] More flexible and null value aware datetime range filter in articles model
avatar richard67 richard67 - edited - 13 Oct 2019
avatar richard67 richard67 - change - 13 Oct 2019
The description was changed
avatar richard67 richard67 - edited - 13 Oct 2019
avatar richard67
richard67 - comment - 14 Oct 2019

@SharkyKZ Done. Thanks for the elegant solution you've proposed. I did it that way.

avatar wilsonge wilsonge - change - 16 Oct 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-10-16 19:32:03
Closed_By wilsonge
avatar wilsonge wilsonge - close - 16 Oct 2019
avatar wilsonge wilsonge - merge - 16 Oct 2019
avatar wilsonge
wilsonge - comment - 16 Oct 2019

Thanks!

Add a Comment

Login with GitHub to post a comment