[#26535] - Add nested mode to Tag fields where applicable
- Fixed in Code Base
- 29 Oct 2019
- Medium
- Build: staging
- # 26535
- Diff
- SharkyKZ:j3/tagField
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Adds mode="nested" attribute to tag fields to prevent data entry. Also changes some fields with custom="deny" to nested mode, for consistency.
Testing Instructions
Create Articles - Category Blog menu item.
In Tags field try to create a tag on the fly.
Expected result
Not possible to add a new tag.
Actual result
Possible to add a new tag. It disappears after saving, but Link field contains such value:
index.php?option=com_content&view=category&layout=blog&id=2&filter_tag[0]=#new#Newly Created Tag
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content Front End com_tags Modules |
I have tested this item
Patch tester reports: The file marked for modification does not exist: administrator/components/com_content/views/articles/tmpl/default.xml
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26535.
@JazParkyn did you by chance test this on 4.0?
Yes - didn’t realise that this wasn’t for J4.0, tired eyes after a long day!
I have not tested this item.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26535.
I have tested this item
Test OK.
However, I don't understand why the field is enabled if you can't add tags.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26535.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26535.
@anibalsanchez I'm not sure what you mean. You're not supposed to be able to create tags on the fly in these forms.
It's confusing. There is an enabled field where you can write a tag but any value is not accepted.
Better if you hide it.
Sorry, I don't follow you. In menu and module forms you should see a tag field where you can select existing tags:
Sure, the tags field has good reason to be visible and enabled in certain cases. However, this PR is about "Not possible to add a new tag." in a specific case.
If it is not possible to add a new tag, then the field is useless in this mode="nested" case.mode="nested". It would be better if the field is disabled or hidden.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-29 14:16:32 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thanks
I have tested this item✅ successfully on efca9c3
Tested successfully on: category blog menu item, popular tags module, tags - compact list menu item, tags - tagged items menu item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26535.