[#26533] - [4.0] tbody-icons with better contrast
- Closed
- 21 Oct 2019
- Medium
- Build: 4.0-dev
- # 26533
- Diff
- chmst:tbody-icons-without-border
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
The icons unpublished and trashed have low contrast. This PR improves the contrast and removes the border from all icons.
When the backend templated started, there were less borders in tables. Now border in the table and border around the icons seems too much. This is a matter of taste, but I suggest to make the icons better visible and the image clearer.
Test needs npm run build:css
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
| Title |
|
||||||
| Labels |
Added:
?
|
||
With a tiny border and a tiny shadow it looks more like a klickable element.
| Title |
|
||||||
thanks for listening - lgtm
Featured/Unfeatured are not distinguishable.
Thank you, now it should be all right.
Unpublished styling is different.
Maybe I have come accustomed to the old styling, I prefer it over this PR.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26533.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26533.
I have tested this item
Test successfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26533.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26533.
There is one suggested change.
| Status | Ready to Commit | ⇒ | Pending |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-21 14:32:09 |
| Closed_By | ⇒ | chmst |
If they were just icons I might agree but they have functionality as well and to me just being an icon on its own does not convey that