Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#26513] - [4.0] Mobile template toolbar

? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
7 Oct 2019

This PR contains the markup for a proposed change to the display of the toggled toolbar.

It is does NOT contain the css changes that are required. I really could do with some help with converting the css below to appropriate scss - or even better scss

You can paste the css below into your browser dev tools after applying the PR to see the intended behaviour

Pull Requests welcome to create the scss
Pull Request for Issue #26486

Demo

2019-10-07_20-17-56

avatar brianteeman brianteeman - open - 7 Oct 2019
avatar brianteeman brianteeman - change - 7 Oct 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Oct 2019
Category ⇒ Administration Templates (admin)
avatar Fedik
Fedik - comment - 8 Oct 2019

@brianteeman place this to /administrator/templates/atum/scss/blocks/_toolbar.scss at bottom and run node build.js --compile-css

@include media-breakpoint-down(xs) {
  .toggler-toolbar {
    top: 20px;

    .toggler-toolbar-icon::before {
      font: normal normal normal 30px/1 'Font Awesome 5 Free';
      content: "\f00d";
      color: var(--toggle-color);
    }

    &.collapsed .toggler-toolbar-icon::before {
      content: "\f085";
    }
  }

  .subhead{

    joomla-toolbar-button,
    .btn-group,
    .btn{
      width: 100%;
    }

    .btn{
      [class^='icon-'],
      [class*=' icon-'],
      [class^='fa-'],
      [class*=' fa-'] {
        float: left;
      }
    }
  }
}
avatar brianteeman brianteeman - change - 13 Oct 2019
Labels Added: ?
avatar brianteeman brianteeman - change - 13 Oct 2019
The description was changed
avatar brianteeman brianteeman - edited - 13 Oct 2019
avatar brianteeman
brianteeman - comment - 13 Oct 2019

Thanks @Fedik

avatar snehaM26 snehaM26 - test_item - 19 Oct 2019 - Tested unsuccessfully
avatar snehaM26
snehaM26 - comment - 19 Oct 2019

I have tested this item ? unsuccessfully on 98a5678

Tested unsuccessfully

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26513.

avatar nidhi1709
nidhi1709 - comment - 19 Oct 2019

Tested successfully

avatar nidhi1709 nidhi1709 - test_item - 19 Oct 2019 - Tested successfully
avatar nidhi1709
nidhi1709 - comment - 19 Oct 2019

I have tested this item ✅ successfully on 98a5678

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26513.

avatar snehaM26 snehaM26 - test_item - 19 Oct 2019 - Tested successfully
avatar snehaM26
snehaM26 - comment - 19 Oct 2019

I have tested this item ✅ successfully on 98a5678

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26513.

avatar snehaM26 snehaM26 - test_item - 19 Oct 2019 - Tested successfully
avatar snehaM26
snehaM26 - comment - 19 Oct 2019

I have tested this item ✅ successfully on 98a5678

Tested successfully.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26513.

avatar brianteeman
brianteeman - comment - 19 Oct 2019

Codestyle changes applied - thanks@quy

avatar Quy Quy - change - 19 Oct 2019
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 19 Oct 2019

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26513.

avatar HLeithner HLeithner - close - 19 Oct 2019
avatar HLeithner HLeithner - merge - 19 Oct 2019
avatar HLeithner HLeithner - change - 19 Oct 2019
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-10-19 09:31:08
Closed_By ⇒ HLeithner
Labels Added: ?
avatar HLeithner
HLeithner - comment - 19 Oct 2019

Thanks.

avatar infograf768
infograf768 - comment - 19 Oct 2019

Totally dead in RTL where the icons buttons are misplaced (tested after also using PR #26613 which also corrects the place of the toggler)

Screen Shot 2019-10-19 at 10 52 12

avatar infograf768
infograf768 - comment - 19 Oct 2019

Making patch for RTL now.

Add a Comment

Login with GitHub to post a comment