User tests: Successful: Unsuccessful:
Pull Request for Issue #24535 (part).
This Pull Request (PR) changes com_checkin so that when you check in a checkout item not with the lock icon in the particular component's but with com_checkin, e.g. the "Checked out" view in backend, a real NULL value is written to the checked_out_time
column of that component's database table if the table allows that (J4 core). If the table does not allow that (e.g. because belonging to a 3rd party extension which has not adapted yet to the null value support for datetimes in J4), the old (pseudo-)nulldates are written to the checked_out_time
column of that component's database table like it was before.
Pre-conditions: Clean, new installation of current 4.0-dev branch or a nightly 4.0-alpha12-dev build (or 4.0 Alpha-12 if already out) not older than the one from this morning (UTC).
checked_out_time
column of the particular table (eg #__content
, #__categories
, #__contact_details
...) in database eg with PhpMyAdmin or PhpPgAdmin, depending on your database.To be extecuted directly after the previous Test A.
#__content
(if testing with an article) or #__categories
(if testing with an article) ... the null
property for column checked_out_time
so null values are not allowed anymore, and enter a valid default value, e.g. '1999-01-01 00:00:00'. (You could also use eg '0000-00-00 00:00:00' on MySQL like an old 3rd party extension would do, but if strict mode is enabled this will not be allowed, so better test with some other default).checked_out_time
column of the particular table (eg #__content
, #__categories
, #__contact_details
...) in database eg with PhpMyAdmin or PhpPgAdmin, depending on your database.After test, don't forget to change back data structure to like it was before if you want to reuse the installation for other tests.
Items being checked in with com_checkin will have column checked_out_time
with real NULL value in their database table if the column allows NULL values. This is the case with Joomla 4 Core since this night.
If the database table does not allow NULL values for column checked_out_time
, which might be the case for 3rd party extensions not being adapted to null value support for datetimes in J4, the old (pseduo-)nulldates ('0000-00-00 00:00:00' with MySQL, '1970-01-01 00:00:00' with PostgreSQL) are saved in that column.
Items being checked in with com_checkin will have checked_out_time
with value '0000-00-00 00:00:00' in a MySQL or '1970-01-01 00:00:00' in a PostgreSQL database in any case.
None.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_checkin |
Title |
|
Labels |
Added:
?
|
Please wait until I've reported back there that I have tested it myself.
I have tested this item
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-19 22:06:41 |
Closed_By | ⇒ | wilsonge |
Thanks!
@wilsonge This one here does not depend on any other PR now because only users is left with datetime stuff, and users don't have a checked out time ;-)