? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
6 Oct 2019

Pull Request for Issue #26151 .

Summary of Changes

more readable code

Testing Instructions

change memory_limit setting in you php.ini
restart apache

Expected result

warning if less than 8M or less than 16M
no warning if greater than 16M

avatar alikon alikon - open - 6 Oct 2019
avatar alikon alikon - change - 6 Oct 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Oct 2019
Category ⇒ Administration com_installer
avatar rdeutz rdeutz - change - 12 Oct 2019
Labels Added: ?
avatar flyingwombats flyingwombats - test_item - 19 Oct 2019 - Tested successfully
avatar flyingwombats
flyingwombats - comment - 19 Oct 2019

I have tested this item ✅ successfully on edf0e2f

Tested and watched the warnings change with the correct memory limits, thanks for patch


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26488.

avatar simonsigns simonsigns - test_item - 19 Oct 2019 - Tested successfully
avatar simonsigns
simonsigns - comment - 19 Oct 2019

I have tested this item ✅ successfully on edf0e2f

Tested - working.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26488.

avatar Quy Quy - change - 19 Oct 2019
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 19 Oct 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26488.

avatar wilsonge wilsonge - change - 19 Oct 2019
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-10-19 11:10:09
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 19 Oct 2019
avatar wilsonge wilsonge - merge - 19 Oct 2019
avatar wilsonge
wilsonge - comment - 19 Oct 2019

Thanks!

Add a Comment

Login with GitHub to post a comment