? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
5 Oct 2019

Summary of Changes

Replaces JOIN and GROUP clauses in query with a subquery for improved performance.

Testing Instructions

Set up a multilingual site.
Enable language associations.
Create some newsfeeds with and without associations
View newsfeed list in backend.

Expected result

Works like before.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 5 Oct 2019
avatar SharkyKZ SharkyKZ - change - 5 Oct 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2019
Category Administration com_newsfeeds
avatar richard67
richard67 - comment - 5 Oct 2019

@SharkyKZ Please replace "contact" by "newsfeed" in your description ;-)

avatar SharkyKZ SharkyKZ - change - 5 Oct 2019
The description was changed
avatar SharkyKZ SharkyKZ - edited - 5 Oct 2019
avatar richard67 richard67 - test_item - 5 Oct 2019 - Tested successfully
avatar richard67
richard67 - comment - 5 Oct 2019

I have tested this item successfully on c83e299

Tested with MySQL 5.7 and PostgreSQL 10.10.

About performance I can't say anything because my test data set is too small.

But I can confirm everything works as well as before, carefully watching PHP error log with PHP error reporting set to maximum and watching database log.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26483.

avatar SharkyKZ
SharkyKZ - comment - 5 Oct 2019

@richard67 Changed. Thanks.

avatar alikon alikon - test_item - 5 Oct 2019 - Tested successfully
avatar alikon
alikon - comment - 5 Oct 2019

I have tested this item successfully on c83e299


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26483.

avatar alikon alikon - change - 5 Oct 2019
Status Pending Ready to Commit
avatar alikon
alikon - comment - 5 Oct 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26483.

avatar wilsonge wilsonge - change - 6 Oct 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-10-06 20:38:04
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 6 Oct 2019
avatar wilsonge wilsonge - merge - 6 Oct 2019
avatar wilsonge
wilsonge - comment - 6 Oct 2019

Thanks!

Add a Comment

Login with GitHub to post a comment