? ? ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
5 Oct 2019

Summary of Changes

Add the username in the backend status bar.

user-name

Votes

# of Users Experiencing Issue
2/2
Average Importance Score
4.00

avatar chmst chmst - open - 5 Oct 2019
avatar chmst chmst - change - 5 Oct 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2019
Category Modules Administration
avatar richard67
richard67 - comment - 5 Oct 2019

To be honest, for me it is ok like it is now, I see "User Menu", and when I click on it I see my name. We will see what others say.

avatar ChristineWk ChristineWk - test_item - 5 Oct 2019 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 5 Oct 2019

I have tested this item successfully on 808031f

it's OK for me - both :-)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26481.

avatar chmst
chmst - comment - 5 Oct 2019

I use to play different roles when working on a site to be sure that all ACL is correct. Somteimes as super user, sometimes as a manger or in another role. And use to forget which role I am playing. :)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26481.

avatar ChristineWk
ChristineWk - comment - 5 Oct 2019

Of course, this makes sense :-)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26481.

avatar chmst chmst - change - 5 Oct 2019
Labels Added: ?
avatar ChristineWk ChristineWk - test_item - 5 Oct 2019 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 5 Oct 2019

I have tested this item successfully on 72d87fa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26481.

avatar ChristineWk
ChristineWk - comment - 5 Oct 2019

I have tested this item successfully on 72d87fa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26481.

avatar brianteeman
brianteeman - comment - 5 Oct 2019

There is an a11y issue with this chambe as the drop-down menu no longer has a sensible description

avatar chmst
chmst - comment - 5 Oct 2019

@brianteeman you are right. It is a pitty, it would be more friendly and individual, if the users sees his/her name.
I can make a Text like this "Pierre Dupont, your User Menu" but this will be truncated in the module.

avatar astridx
astridx - comment - 5 Oct 2019

@chmst Perhaps you can use 'sr-only' for the long text?

avatar brianteeman
brianteeman - comment - 5 Oct 2019

I really think your use case is an exception and not a norm

avatar richard67
richard67 - comment - 5 Oct 2019

By the way: In database, the user name column can be up to 400 characters long. What if someone has a very long name? Shall that really all be displayed at that place?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26481.

avatar alikon
alikon - comment - 5 Oct 2019

I like this concept, despite i cannot suggest a more good way to do this, but i really would like to know in a easy way --- who am I

avatar richard67
richard67 - comment - 5 Oct 2019

Who am I ... and how many? ;-)

avatar brianteeman
brianteeman - comment - 5 Oct 2019

@alikon not really that hard :)
image

avatar alikon
alikon - comment - 5 Oct 2019

philosophical question apart, ?
make sense to me... but
i know i'm not so good at UI/UX just my 2eurocent

avatar joomla-cms-bot joomla-cms-bot - change - 6 Oct 2019
Category Modules Administration Administration Language & Strings Modules
avatar chmst
chmst - comment - 6 Oct 2019

@richard67 Long names would be truncated .

@brianteeman I can make an override of the module for myself, and I do not insist to bring this into the core.
But I see in different applications my avatar and/or user name, and I like it, it is more personal and friendly.

I'll commit a small change and with my long name it looks like this:

username

avatar ChristineWk ChristineWk - test_item - 6 Oct 2019 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 6 Oct 2019

I have tested this item successfully on 5555b2b

OK, I gave it a 3rd try - but have short User Name :-)
So, it looks OK, even it's truncated - in your case. What about user, inserting as User Name: Super User :-)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26481.
avatar Chessy65
Chessy65 - comment - 7 Oct 2019

I have tested this item white_check_mark successfully on 5555b2b

avatar infograf768 infograf768 - change - 9 Oct 2019
Labels Added: ?
avatar Quy
Quy - comment - 9 Oct 2019

I find this wordy. I like the way before this PR.

avatar scott-qld scott-qld - test_item - 19 Oct 2019 - Tested unsuccessfully
avatar scott-qld
scott-qld - comment - 19 Oct 2019

I have tested this item ? unsuccessfully on 82576dc

Patch could not be applied due to exception with administrator/components/com_media/package-lock.json. Joomla\Filesystem\File::move: Rename failed.
PHP Built On Linux joomlapbf.directrouter.com 2.6.32-754.3.5.el6.x86_64 #1 SMP Tue Aug 14 20:46:41 UTC 2018 x86_64
Database Type mysql
Database Version 10.2.27-MariaDB
Database Collation utf8mb4_unicode_ci
Database Connection Collation utf8mb4_general_ci
PHP Version 7.2.23
Web Server Apache
WebServer to PHP Interface cgi-fcgi
Joomla! Version Joomla! 4.0.0-beta1-dev Development [ Amani ] 17-October-2019 20:21 GMT
User Agent Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26481.

avatar manojLondhe manojLondhe - test_item - 19 Oct 2019 - Tested successfully
avatar manojLondhe
manojLondhe - comment - 19 Oct 2019

I have tested this item successfully on 82576dc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26481.

avatar infograf768
infograf768 - comment - 19 Oct 2019

Agree with @Quy
The User Name is immediately visible in the dropdown when clicking on the icon. No need to change imho.

avatar uthorat uthorat - test_item - 19 Oct 2019 - Tested successfully
avatar uthorat
uthorat - comment - 19 Oct 2019

I have tested this item successfully on 82576dc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26481.

avatar idefax idefax - test_item - 19 Oct 2019 - Tested successfully
avatar idefax
idefax - comment - 19 Oct 2019

I have tested this item successfully on 82576dc

Works fine.

Tested on:

PHP Version 7.3.8
Web Server Apache
WebServer to PHP Interface cgi-fcgi
Joomla! Version Joomla! 4.0.0-beta1-dev Development [ Amani ] 17-October-2019 20:21 GMT
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26481.

avatar brianteeman
brianteeman - comment - 19 Oct 2019

I am not in favour of this change

avatar richard67
richard67 - comment - 19 Oct 2019

Me neither, but I won't block it if many people want it.

avatar snehaM26 snehaM26 - test_item - 19 Oct 2019 - Tested successfully
avatar snehaM26
snehaM26 - comment - 19 Oct 2019

I have tested this item successfully on 82576dc

Tested successfully


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26481.

avatar LukasHH LukasHH - test_item - 19 Oct 2019 - Tested successfully
avatar LukasHH
LukasHH - comment - 19 Oct 2019

I have tested this item successfully on 82576dc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26481.

avatar neotrendch neotrendch - test_item - 19 Oct 2019 - Tested successfully
avatar neotrendch
neotrendch - comment - 19 Oct 2019

I have tested this item successfully on 82576dc

good to see the username without click


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26481.

avatar richard67
richard67 - comment - 19 Oct 2019

Guys, 2 successful tests are enough for a Pull Request to get the "Ready to Commit" status. As soon as a PR has this, it does not need more tests, and you can focus on other PR's which still need tests.

avatar oschuldt oschuldt - test_item - 19 Oct 2019 - Tested successfully
avatar oschuldt
oschuldt - comment - 19 Oct 2019

I have tested this item successfully on 82576dc

works!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26481.
avatar patjun patjun - test_item - 19 Oct 2019 - Tested successfully
avatar patjun
patjun - comment - 19 Oct 2019

I have tested this item successfully on 82576dc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26481.

avatar karo3 karo3 - test_item - 19 Oct 2019 - Tested successfully
avatar karo3
karo3 - comment - 19 Oct 2019

I have tested this item successfully on 82576dc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26481.

avatar richard67
richard67 - comment - 19 Oct 2019

Guys, 2 successful tests are enough for a Pull Request to get the "Ready to Commit" status. As soon as a PR has this, it does not need more tests, and you can focus on other PR's which still need tests.

avatar riishede
riishede - comment - 19 Oct 2019

I have tested this item succesfully on 82576dc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26481.

avatar richard67 richard67 - change - 19 Oct 2019
Title
Add the username to the statusbar
[4.0] Add the username to the statusbar
avatar joomla-cms-bot joomla-cms-bot - edited - 19 Oct 2019
avatar CodeOfConduct CodeOfConduct - test_item - 19 Oct 2019 - Tested successfully
avatar CodeOfConduct
CodeOfConduct - comment - 19 Oct 2019

I have tested this item successfully on 82576dc

It worked for me :).


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26481.

avatar pascalelocher pascalelocher - test_item - 19 Oct 2019 - Tested successfully
avatar pascalelocher
pascalelocher - comment - 19 Oct 2019

I have tested this item successfully on 82576dc

PHP Version 7.3.8
Web Server Apache
WebServer to PHP Interface cgi-fcgi
Joomla! Version Joomla! 4.0.0-beta1-dev Development [ Amani ] 17-October-2019 20:21 GMT
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26481.

avatar blueforce blueforce - test_item - 19 Oct 2019 - Tested successfully
avatar blueforce
blueforce - comment - 19 Oct 2019

I have tested this item successfully on 82576dc

works as expected
tested with:
PHP Version 7.3.8
Web Server Apache
WebServer to PHP Interface cgi-fcgi
Joomla! Version Joomla! 4.0.0-alpha12-dev Development [ Amani ] 19-August-2019 13:40 GMT
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.120 Safari/537.36


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26481.
avatar alikon alikon - change - 20 Oct 2019
Status Pending Ready to Commit
avatar alikon
alikon - comment - 20 Oct 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26481.

avatar Quy
Quy - comment - 20 Oct 2019

There is 1 suggested change.

avatar chmst
chmst - comment - 21 Oct 2019

I think it is a11y now, without further changes? @brianteeman
@astridx - A sr-only text was a good idea, but now is not necessary, as the name and function both are visible on the dropdown.

But I do not insist on this PR, I can make overrides :)

I would even like to have an avatar here like github to make the backend individual, but it is not possible in this version.

avatar brianteeman
brianteeman - comment - 21 Oct 2019
  1. There is a change requested by @Quy that is valid and must be addressed before this can be considered for merging

  2. As someone with a long name themself I am not a fan of seeing my name truncated and nor do I see any benefit

  3. As I was asked - I do not see any accessibility issue with this pr

avatar chmst chmst - change - 21 Oct 2019
Labels Added: ?
avatar chmst
chmst - comment - 21 Oct 2019

As this is a matter of taste and everyone can make an override for its own, I close this for now.

avatar chmst chmst - change - 21 Oct 2019
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2019-10-21 15:20:46
Closed_By chmst
avatar chmst chmst - close - 21 Oct 2019

Add a Comment

Login with GitHub to post a comment