User tests: Successful: Unsuccessful:
Status | New | ⇒ | Pending |
Category | ⇒ | Modules Administration |
I have tested this item
it's OK for me - both :-)
I use to play different roles when working on a site to be sure that all ACL is correct. Somteimes as super user, sometimes as a manger or in another role. And use to forget which role I am playing. :)
Of course, this makes sense :-)
Labels |
Added:
?
|
I have tested this item
I have tested this item
There is an a11y issue with this chambe as the drop-down menu no longer has a sensible description
@brianteeman you are right. It is a pitty, it would be more friendly and individual, if the users sees his/her name.
I can make a Text like this "Pierre Dupont, your User Menu" but this will be truncated in the module.
I really think your use case is an exception and not a norm
By the way: In database, the user name column can be up to 400 characters long. What if someone has a very long name? Shall that really all be displayed at that place?
I like this concept, despite i cannot suggest a more good way to do this, but i really would like to know in a easy way --- who am I
Who am I ... and how many? ;-)
philosophical question apart,
make sense to me... but
i know i'm not so good at UI/UX just my 2eurocent
Category | Modules Administration | ⇒ | Administration Language & Strings Modules |
@richard67 Long names would be truncated .
@brianteeman I can make an override of the module for myself, and I do not insist to bring this into the core.
But I see in different applications my avatar and/or user name, and I like it, it is more personal and friendly.
I'll commit a small change and with my long name it looks like this:
I have tested this item
OK, I gave it a 3rd try - but have short User Name :-)
So, it looks OK, even it's truncated - in your case. What about user, inserting as User Name: Super User :-)
Labels |
Added:
?
|
I find this wordy. I like the way before this PR.
I have tested this item
Patch could not be applied due to exception with administrator/components/com_media/package-lock.json. Joomla\Filesystem\File::move: Rename failed.
PHP Built On Linux joomlapbf.directrouter.com 2.6.32-754.3.5.el6.x86_64 #1 SMP Tue Aug 14 20:46:41 UTC 2018 x86_64
Database Type mysql
Database Version 10.2.27-MariaDB
Database Collation utf8mb4_unicode_ci
Database Connection Collation utf8mb4_general_ci
PHP Version 7.2.23
Web Server Apache
WebServer to PHP Interface cgi-fcgi
Joomla! Version Joomla! 4.0.0-beta1-dev Development [ Amani ] 17-October-2019 20:21 GMT
User Agent Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0
I have tested this item
I have tested this item
I have tested this item
Works fine.
Tested on:
PHP Version 7.3.8
Web Server Apache
WebServer to PHP Interface cgi-fcgi
Joomla! Version Joomla! 4.0.0-beta1-dev Development [ Amani ] 17-October-2019 20:21 GMT
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0
I am not in favour of this change
Me neither, but I won't block it if many people want it.
I have tested this item
Tested successfully
I have tested this item
I have tested this item
good to see the username without click
Guys, 2 successful tests are enough for a Pull Request to get the "Ready to Commit" status. As soon as a PR has this, it does not need more tests, and you can focus on other PR's which still need tests.
I have tested this item
works!
I have tested this item
I have tested this item
Guys, 2 successful tests are enough for a Pull Request to get the "Ready to Commit" status. As soon as a PR has this, it does not need more tests, and you can focus on other PR's which still need tests.
I have tested this item succesfully on 82576dc
Title |
|
I have tested this item
It worked for me :).
I have tested this item
PHP Version 7.3.8
Web Server Apache
WebServer to PHP Interface cgi-fcgi
Joomla! Version Joomla! 4.0.0-beta1-dev Development [ Amani ] 17-October-2019 20:21 GMT
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0
I have tested this item
works as expected
tested with:
PHP Version 7.3.8
Web Server Apache
WebServer to PHP Interface cgi-fcgi
Joomla! Version Joomla! 4.0.0-alpha12-dev Development [ Amani ] 19-August-2019 13:40 GMT
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.120 Safari/537.36
Status | Pending | ⇒ | Ready to Commit |
RTC
There is 1 suggested change.
I think it is a11y now, without further changes? @brianteeman
@astridx - A sr-only text was a good idea, but now is not necessary, as the name and function both are visible on the dropdown.
But I do not insist on this PR, I can make overrides :)
I would even like to have an avatar here like github to make the backend individual, but it is not possible in this version.
There is a change requested by @Quy that is valid and must be addressed before this can be considered for merging
As someone with a long name themself I am not a fan of seeing my name truncated and nor do I see any benefit
As I was asked - I do not see any accessibility issue with this pr
Labels |
Added:
?
|
As this is a matter of taste and everyone can make an override for its own, I close this for now.
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-21 15:20:46 |
Closed_By | ⇒ | chmst |
To be honest, for me it is ok like it is now, I see "User Menu", and when I click on it I see my name. We will see what others say.