[#26478] - 4.0] add module position to module default chrome
- Closed
- 5 Oct 2019
- Medium
- Build: 4.0-dev
- # 26478
- Diff
- Scrabble96:4.0]-Add-module-position-to-module-default-chrome
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
In order to allow easy custom css changes per module type, add the module position to line 26 of this file. This also applies to the cardGrey chrome.
Pull Request for Issue #26095 (last comment) .
Summary of Changes
Current code:
Proposed code to allow styling of body section in modules in different positions, particularly for custom modules, but it may well apply to other types, too:
I wanted to do this for cardGrey.php at the same time, but can't work out how to modify more than one file at a time.
Testing Instructions
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
| Labels |
Added:
?
|
||
I have tested this item
? unsuccessfully on 662ba18If you have a position, which exists as CSS class, your code breaks (like "nav").
You have the module class suffix to add custom styling.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26478.
Thanks. I mentioned that I could do this PR on the last comment of issue #26095 over a month ago on 1st September. No-one has commented since then to say that it was necessary to do so, so I went ahead with the PR. I shall now close this comment and also try to work out how to remove all the other older commits which seem to get added automatically to new PRs.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-05 09:53:36 |
| Closed_By | ⇒ | Scrabble96 |
I have tested this item? unsuccessfully on 662ba18
If you have a position, which exists as CSS class, your code breaks (like "nav").
You have the module class suffix to add custom styling.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26478.