[#26467] - [4.0] Autocomplete fields
- Fixed in Code Base
- 6 Oct 2019
- Medium
- Build: 4.0-dev
- # 26467
- Diff
- brianteeman:password
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull request for #26459
The docblock in all fields is wrong
All we ever do is see if it is "on" or "off"
For example
Which means that we can never have any value for autocomplete in the xml other than 'off'
You can see this by changing the value for autocomplete here to anything else and instead of the autocomplete being output with the new value it is removed.
joomla-cms/administrator/components/com_users/forms/user.xml
Lines 20 to 30 in bc42bb1
Autocomplete has a lot of useful values that we could/should be using see https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete
For example autocomplete=off really doesn't do anything on password fields. Instead we should be using autocomplete="new-password"
This PR allows for the correct usage of the autocomplete element so that it supports all element values.
Testing is super simple. Apply the PR and then edit or add an autocomplete element to any field xml and see what is generated in the source
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout Libraries |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26467.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26467.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-06 20:53:18 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
Thanks!
Thanks
I have tested this item✅ successfully on 3886e84
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26467.