[#26465] - [4.0] Improve article list performance on multilingual sites
- Fixed in Code Base
- 6 Oct 2019
- Medium
- Build: 4.0-dev
- # 26465
- Diff
- SharkyKZ:j4/query/articlesMultilang
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #25770.
Summary of Changes
Replaces JOIN and GROUP clauses in query with a subquery.
Testing Instructions
Set up a multilingual site.
Enable associations.
Create some articles and add associations.
View article list in backend.
Expected result
Works like before.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content |
What language have you used in the installation step ?
i've tryied persian , french always got this trying to add multilanguage content sample data
Sometimes content languages are not added after language install. I've helped myself then with uninstalling languages and installing again.
seems that German - DE allows me to run sample multilanguage data (just for note on postgresql now)
I'm using German (DE), French and for RTC sometimes Persian.
| Labels |
Added:
?
|
||
I have tested this item
Tested with MySQL 5.7 and PostgreSQL 10.10.
About performance I can't say anything because my test data set is too small.
But I can confirm everything works as well as before, carefully watching PHP error log with PHP error reporting set to maximum and watching database log.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26465.
@SharkyKZ ok maybe another issue to open if it will be still there when we will have languages pack ready for 4, anyway PR seems fine & all works as before , despite i don't have a good big dataset to do some real case performance check... i cannot trust my EXPLAIN with my short data , but it looks fine and i cannot guess how it can works worst than now...
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26465.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26465.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-06 20:49:53 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
I have tested this item✅ successfully on 10687ec
Tested with MySQL 5.7 and PostgreSQL 10.10.
About performance I can't say anything because my test data set is too small.
But I can confirm everything works as well as before, carefully watching PHP error log with PHP error reporting set to maximum and watching database log.
There is a PHP notice "Undefined index: link in /layouts/joomla/content/associations.php on line 18" at least when using PostgreSQL before and after having applied this PR, so not related to this PR. This just as info for other testers.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26465.