[#26458] - [4.0] Database Fix button
- Fixed in Code Base
- 3 Oct 2019
- Medium
- Build: 4.0-dev
- # 26458
- Diff
- brianteeman:db-update
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: 2 ChristineWk, alikon Unsuccessful: 0
Currently the button is called Fix and based on the number of times I see people thinking they need to do this all the time and it will magically fix things this PR changes the name to Update Structure
Hopefully it will reduce the number of people who think its a solution to every possible bug
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
| Labels |
Added:
?
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26458.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26458.
@brianteeman
..."Hopefully it will reduce the number of people who think its a solution to every possible bug"
of course :-) OT: That's why I'm checking before:
sorry, I didn't find the image button.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26458.
So the fun part is it does more than db structure :D it also deals with deleting unused files (also normally managed by joomla update and even a piece of 2.5 code migration - that can probably be removed than J4 https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_installer/Model/DatabaseModel.php#L268-L270)
Although in principal this should be separate of course. Some of this stuff is why we need a status page rather than this magic button
Stage 1 is to rename the button - this PR
Stage 2 is separate the non-database code
Stage 3 create the status page
Please make sure at least part 2 comes in the not too distant. else we'll need to revert it before going stable if it's still doing non database things
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-03 15:10:56 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
I have tested this item✅ successfully on 6690b24
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26458.