[#26456] - [4.0] Fix mail templates list display
- Fixed in Code Base
- 6 Oct 2019
- Medium
- Build: 4.0-dev
- # 26456
- Diff
- richard67:4.0-dev-mail-templates-sql-2
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This Pull Request (PR) fixes the list display of mail templates so that nu duplicate items are shown anymore after having changed some settings (e.g. use custom subject) for a particular language.
It also makes filtering by language and saving the changed settings work again after it has stopped working since some previous PR.
Testing Instructions
- Apply the patch pf this PR on a clean 4.0-dev branch and make a new installation.
- In backend, go to mail templates navigating as shown in following screenshot with the red marks:
Result: The mail templates list shows 1 template for extension com_config.test_mail, which shows the language of the installation as only language.
- Install some languages, publish their content languages and go to the mail templates list again.
Result: The mail template shows now flags for all published content languages.
- Open the filter options and check that there are filters by language and extensions.
Result:
- Filter by some language.
Result: No item found. Reason: There has not been made any adjustment to a mail template for a language.
-
Reset the filter so that the item is shown again.
-
Click on a language flag to edit the mail template for that particular language and make some change in the edit view, e.g. enable custom subject.
-
Save and close.
-
Filter again by language and select the language for which you have edited the mail template parameters just before.
Result: The item is shown.
Expected result
See testing instructions above.
Actual result
After having edited and saved the mail template for one language, the list shows two (in case if no language installed) or maybe more (in case if some languages installed) records shown with ID "com_config.test_mail".
Changing mail subject and content for a particular language doesn't work, i.e. changes are not there when editing again.
Additional information
When using the language filter for "All languages", there will never be an item found because there is no item with language='*' in database, and such will never be created. This could be fixed by either removing this option from the language filter (but this would not be consistent with all other language filters anywhere else) or by showing the master item as usual, i.e. without language filter applied.
But this should be done with another PR if necessary/desired.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration |
| Labels |
Added:
?
|
||
Works on PostgreSQL, too
Nice feature btw. these mail templates if you once have understood how they work. Is there already some documentation on it? If not, maybe it could be a task for the PBF to write some? Testing instructions here could be used as a base.
blueforce
- 
Sorry but this language filter makes no sense to me at all.
If I see this
And then filter on EN and see this
it makes no sense to me as a user why there is no english records displayed
When I look in the database then I can see the reason (and it almost makes sense technically) but then the UI needs to be different.
In addition I would expect from the ui that even if I understood why there was no EN record (yet) then there would at least be an ALL record
In fact is it ever possible to have an ALL record?
Or does it mean that ALL will display all the records that exist that have a specified language ie EN and FR and ES
If it is the latter then that's not correct as it is completely different to the rest of Joomla where ALL in a language filter means a record that is for all languages.
Either way it is wrong here
(PS sorting doesnt work at all)
Install some languages, publish their content languages and go to the mail templates list again.
Result: The mail template shows now flags for all published content languages.
It does not take into account if the content language is published only that there is a content language
@brianteeman - you're right the contents of that dropdown do need editing - you can't have an all (i mean the master kinda acts like an all if the language override hasn't been saved for a specific language - so arguably that should show up). However I think it's a separate issue for this PR - which is mainly solving the duplicate items issue whilst keeping the postgres part working. If we could create a separate issue for that would be amazing :)
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-06 10:45:27 |
| Closed_By | ⇒ | wilsonge |
Thanks!
@alikon @brianteeman @Hackwar Please review or test or both.
@alikon
I haven't tested yet on PostgreSQL, maybe you are faster than me? ;-)Done.