?
avatar astridx
astridx
2 Oct 2019

Steps to reproduce the issue

I like to use the change log, that was introduced in this PR: #24026

  1. Install an extension that uses change log and update server. I created my own extension for this. If you like you can test with this extension: https://github.com/astridx/boilerplate/releases/tag/v1.0.0

  2. Make sure, that in the manage view the change log is shown

Extensions  Manage   test   Administration

  1. Create a new version of this extension and open the update view. In my case the update version is version 1.0.1: https://github.com/astridx/boilerplate/releases/tag/v1.0.1

Expected result

I can open the change log in the update view.

Actual result

Open the update view and see, that there is N/A in the column for the change log
Extensions  Update   test   Administration(1)

System information (as much as possible)

Current Joomla 4.0 Branch on Ubuntu. Browser: Firefox

Additional comments

Unfortunately, I can not test with the original files from PR #24026, because they are not available.

avatar astridx astridx - open - 2 Oct 2019
avatar joomla-cms-bot joomla-cms-bot - change - 2 Oct 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 2 Oct 2019
avatar astridx astridx - change - 2 Oct 2019
The description was changed
avatar astridx astridx - edited - 2 Oct 2019
avatar brianteeman
brianteeman - comment - 2 Oct 2019

The problem is in your code not in joomla ;)

You have set the update url to be https://github.com/astridx/boilerplate/blob/tutorial/changelog.xml
But that is the full github html page

You need to change that to be https://raw.githubusercontent.com/astridx/boilerplate/tutorial/changelog.xml

image

avatar astridx
astridx - comment - 2 Oct 2019

@brianteeman Thank you. You're right. I could have seen that myself. Sorry.
But. In the zip of the old version , the URL was right. Only in the zip of the new version, the URL was wrong. I did not expect that. Because the URL was recognized by the manager, I was sure of an error in the update view.

avatar astridx astridx - close - 2 Oct 2019
avatar astridx astridx - change - 2 Oct 2019
Status New Closed
Closed_Date 0000-00-00 00:00:00 2019-10-02 15:20:40
Closed_By astridx
avatar astridx astridx - change - 2 Oct 2019
Status Closed New
Closed_Date 2019-10-02 15:20:40
Closed_By astridx
avatar astridx
astridx - comment - 2 Oct 2019

Now I have corrected the zip. The problem still exists. When I update the change log is not displayed. But: I can see it after the update.

avatar astridx astridx - reopen - 2 Oct 2019
avatar brianteeman
brianteeman - comment - 2 Oct 2019

what is the value of the changelogurl field in the #__extensions database table

avatar astridx
astridx - comment - 2 Oct 2019

@brianteeman Thank you for helping.
The changelogurl is:
https://raw.githubusercontent.com/astridx/boilerplate/tutorial/changelog.xml
In the manage view I can open the change log. The problem is in the update view
localhost   localhost   joomla_db4   sdmgh_extensions   phpMyAdmin 4 9 0 1

avatar brianteeman
brianteeman - comment - 2 Oct 2019

When I update the change log is not displayed

Nothing is being displayed in updates view
image

This is the expected behaviour as there is no update to the version that is installed defined in your update server.

avatar astridx
astridx - comment - 2 Oct 2019

@brianteeman
I did not express myself well. I mean, when have installed version 1.0.0 and I check for updates. In this case I see this:
Extensions  Update   test   Administration(1)
But I should see a link in the column change log to the change log for version 1.0.1.
So it is explained in #24026
@roland-d That's correct, right?

avatar brianteeman
brianteeman - comment - 2 Oct 2019

you dont have a changelog url defined in your update xml so the #__updates changelogurl field never gets populated

The code is working correctly as far as I can tell. The problem is the documentation is missing

avatar roland-d
roland-d - comment - 2 Oct 2019
avatar brianteeman
brianteeman - comment - 2 Oct 2019

Grrrh, search sucks on that site.

@astridx the docs confirm what I wrote

avatar astridx astridx - change - 2 Oct 2019
Status New Closed
Closed_Date 0000-00-00 00:00:00 2019-10-02 20:46:35
Closed_By astridx
avatar astridx
astridx - comment - 2 Oct 2019

I am ashamed, but I have seen the entry in update.xml just now in JDoc. Before I did not see it. Many thanks for your help and sorry for the wrong error report.

avatar astridx astridx - close - 2 Oct 2019
avatar brianteeman
brianteeman - comment - 2 Oct 2019

Happens to all of us

Add a Comment

Login with GitHub to post a comment