? Pending

User tests: Successful: Unsuccessful:

avatar astridx
astridx
2 Oct 2019

Pull Request for Issue #26373.

Summary of Changes

I changed the position of the module that displayed the version number to the bottom.
I changed the position of the module that displayed the version number. See #26447 (comment)

Testing Instructions

  1. Apply this patch.

  2. Make a new installation (Have to update SQL in order for the patch to work).

  3. See, that the version number is now on the right side of the bottom at the top right corner.

  4. See, that no version number is displayed in the top menu.

Documentation Changes Required

No

avatar astridx astridx - open - 2 Oct 2019
avatar astridx astridx - change - 2 Oct 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Oct 2019
Category Administration Language & Strings Modules Templates (admin) SQL Installation Postgresql
avatar astridx astridx - change - 2 Oct 2019
Title
version number
[4.0] version number
avatar astridx astridx - edited - 2 Oct 2019
avatar astridx astridx - change - 2 Oct 2019
Labels Added: ? ?
avatar N6REJ
N6REJ - comment - 2 Oct 2019

TY TY TY TY TY, I think I put an issue in for this...or maybe I just ranted

avatar N6REJ N6REJ - test_item - 2 Oct 2019 - Tested unsuccessfully
avatar N6REJ
N6REJ - comment - 2 Oct 2019

I have tested this item ? unsuccessfully on 8e6f08b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26447.

image

avatar astridx
astridx - comment - 2 Oct 2019

@N6REJ Thank you for testing. Did you make a new installation of Joomla!?
What is the exact error message?

avatar N6REJ
N6REJ - comment - 2 Oct 2019

If you made a "new" installation the patch wouldn't exist ?
I did
-git reset --hard
-git pull -f
-add patch
-npm ci
test.

There is no 'error' that was displayed. If you look where the version WAS you'll see that its just messy text now.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26447.
Looking at the files, I wonder if the sql was actually applied? If that is the cause?

avatar astridx
astridx - comment - 2 Oct 2019

@N6REJ
Please try:

  1. Add the patch via patch tester.
  2. Delete or rename the file configuration.php.
  3. Run a new installation.

If you like do delete the patch via patch tester, you can discover install patch tester.

avatar N6REJ N6REJ - test_item - 2 Oct 2019 - Tested successfully
avatar N6REJ
N6REJ - comment - 2 Oct 2019

I have tested this item successfully on 8e6f08b

Must manually update SQL in order for the patch to work.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26447. ![image](https://user-images.githubusercontent.com/1850089/66072277-618c3600-e51a-11e9-8c62-b6141a2dac85.png)
avatar N6REJ
N6REJ - comment - 2 Oct 2019

@N6REJ
Please try:

  1. Add the patch via patch tester.
  2. Delete or rename the file configuration.php.
  3. Run a new installation.

how is doing a new installation going to keep the patch?

avatar astridx
astridx - comment - 2 Oct 2019

@N6REJ
That has overlapped. Great. Thank you very much for testing.

avatar N6REJ
N6REJ - comment - 2 Oct 2019

might want to modify the testing instructions

avatar alikon alikon - test_item - 2 Oct 2019 - Tested successfully
avatar alikon
alikon - comment - 2 Oct 2019

I have tested this item successfully on 8e6f08b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26447.

avatar alikon alikon - change - 2 Oct 2019
Status Pending Ready to Commit
avatar alikon
alikon - comment - 2 Oct 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26447.

avatar astridx astridx - change - 2 Oct 2019
The description was changed
avatar astridx astridx - edited - 2 Oct 2019
avatar wilsonge
wilsonge - comment - 3 Oct 2019

I'm not convinced we want this? Part of the design of the new template is to remove the footer. Why is having the version in the header so totally wrong?

avatar astridx
astridx - comment - 3 Oct 2019

I felt like @N6REJ .

  1. I also thought something had to be clicked here because the version looks like a button.
  2. I also believe that information that is not incidental should be displayed below.
  3. Plus, I think it's great to create the design the way most people expect it to. I did not do a big survey, but people around me are expecting the version number in the footer.

Is there a reason why the footer was removed?

Addition: It is not a real footer. It will be displayed under the content:
Articles  Featured   test   Administration

avatar brianteeman
brianteeman - comment - 3 Oct 2019

I agree that currently it looks like its something you should click on
I agree that it probably doesn't need to be so prominent
I dont agree with this PR for the reason shown in your last screenshot

avatar astridx
astridx - comment - 3 Oct 2019

So, you would prefer this (sorry I've cut too tight, but I think you see what I mean):

Articles   test   Administration

avatar astridx astridx - change - 3 Oct 2019
Labels Added: ?
avatar N6REJ
N6REJ - comment - 3 Oct 2019

@astridx how about moving it to the status page? Do we really need it on every page?
If it needs to be on every page then lets make it ...
no graphics
centered H6 like ...

Joomla! 3.9.12 — © 2019 Acorn Local Dev

maybe even opacity: .7

avatar astridx
astridx - comment - 3 Oct 2019

@N6REJ It is already there:
System Information   test   Administration(1)

avatar brianteeman
brianteeman - comment - 3 Oct 2019

@astridx personally yes

@bear

do we really need it on every page?

You can make that comment about everything

avatar N6REJ
N6REJ - comment - 3 Oct 2019

Here is where I meant but as you see it's already there... lets just remove it then!
image

avatar brianteeman
brianteeman - comment - 3 Oct 2019

depends if you publish that module

avatar N6REJ
N6REJ - comment - 3 Oct 2019

it's pre-published during install brian

avatar chmst
chmst - comment - 3 Oct 2019

Did you do the test also on your smartphones?

joomla-version

The module should add a warning the version number if the version ist not up to date.
It was expected that people see this better in in the prominent place in the header.

You can ask if it is necessary - but we want that every Joomla Version is always up to date. No casual user will search for the version number in the stats module or system information.

avatar astridx
astridx - comment - 4 Oct 2019

@chmst Thank you for checking.

For me it looks like this on the Smartphone:

Articles   test   Administration(3)

But you are right. I did not test it correctly. If the screen width is less than 460px or debug mode is enabled, the version number disappears. That's why I gave the element with the version number a margin and a padding in the last commit. Now it looks like this:

Articles   test   Administration(2)
Articles   test   Administration(1)
Articles   test   Administration(4)

Without the version number we could perhaps position the buttons in the mobile foot menu directly and you would not have to open something extra.

What exactly do you mean with:

The module adds a warning badge to the version number if the version ist not up to date.

I can not find a program code in the module that displays a warning if the version is outdated. Can you point me there please?

Without knowing the code, I wonder if the Quick-icon and the Joomla Updater update-hint are not enough to inform the user about an existing new version.
Control Panel   test   Administration

avatar Quy Quy - change - 4 Oct 2019
Status Ready to Commit Pending
avatar astridx astridx - change - 4 Oct 2019
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 4 Oct 2019
Category Administration Language & Strings Modules Templates (admin) SQL Installation Postgresql Administration Language & Strings Modules Templates (admin) JavaScript Repository NPM Change SQL Installation Postgresql
8b8a28c 4 Oct 2019 avatar astridx lint
avatar astridx astridx - change - 4 Oct 2019
Labels Added: NPM Resource Changed
avatar astridx
astridx - comment - 4 Oct 2019

I just added more changes. The top menu in the "footer" has now the following changes (for me improvements):

  1. I use the whole free space for showing the icons.

Before, there was often free space in the bar, although other icons were available.
Control Panel   test   Administration(1)

  1. If there is not enough space the icons are put into a fly-out menu that you can open with the toggler.

That was already so before. My change: It does not happen that icons are hidden like in this picture:
Control Panel   test   Administration(3)

  1. The fly-out menu has one column. So it can not happen, that there is much empty space like in the next picture.

Control Panel   test   Administration(2)

I hope I did not miss something again.

@N6REJ @alikon Would you please test again with this changes?

avatar infograf768
infograf768 - comment - 5 Oct 2019

I am concerned by the position of the Update Checks module in the Control Panel page. This before and after this patch. But it’s even worse when a unique column is used in smaller screens.

In 3.x we have an alert/message always displaying on top of the page. In 4.0 it is very easy to miss that module as one has to scroll a lot to be informed about updates.

Is there a way (by js as it looks like we can’t avoid these complex js for almost all in J4) to move that entire module to top when there are updates?

avatar bembelimen
bembelimen - comment - 5 Oct 2019

Sorry, I fully disagree with this PR.

This PR does not deliver any benefits to the system. It just make the current version less visible + implements a footer where we don't want any footer.

I think we should raise awareness to the installed version + should always point out if the version is out of date.

Additionally if you check the Joomla! 3 version and compare with Joomla! 4 you'll see, that the version button is now an own module, so if it's annoys you, you can disable it with one click.

But version in the footer? No!

Perhaps we can adjust the module in header that way, that it does not look clickable (which is given imho, because there is absolute no indication, that this icon is clickable)

avatar brianteeman
brianteeman - comment - 5 Oct 2019

maybe there is some other way to make it look less like a button?

avatar chmst
chmst - comment - 5 Oct 2019

I agree that the appearance of the version module needs to be improved.

But do not see any advantage in moving the module to a footer. In modern applications I am used to find all mstatus informations top right not some information on the top, some at the end of the screen.
It seems not ergonomic to me, the eye must search for the information above the screen.
As @bembelimen says, you can move the module at the end of your dashboard.

avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2019
Category Administration Language & Strings Modules Templates (admin) SQL Installation Postgresql JavaScript Repository NPM Change Administration Language & Strings Modules Templates (admin) SQL Installation Postgresql
avatar astridx astridx - change - 5 Oct 2019
Labels Removed: NPM Resource Changed
avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2019
Category Administration Language & Strings Modules Templates (admin) SQL Installation Postgresql Modules Administration Templates (admin) SQL Installation Postgresql
avatar astridx
astridx - comment - 5 Oct 2019

What do you say to this:
Articles  New   test   Administration(2)
Articles  New   test   Administration(1)

avatar astridx astridx - change - 5 Oct 2019
The description was changed
avatar astridx astridx - edited - 5 Oct 2019
avatar astridx astridx - change - 5 Oct 2019
The description was changed
avatar astridx astridx - edited - 5 Oct 2019
avatar bembelimen
bembelimen - comment - 5 Oct 2019

To make it easy: why not link to the Joomla updater?

avatar N6REJ
N6REJ - comment - 6 Oct 2019

why not to the right of the J! icon? Wouldn't that make the most sense?
or as a tooltip for the J! icon?

avatar astridx
astridx - comment - 6 Oct 2019

@N6REJ why not to the right of the J! icon?

because most voted for the top right and because the space on a narrow display is better used. I tried it:

Control Panel   test   Administration(5)
Control Panel   test   Administration(4)

I also put it in the SVG logo as <text>. But then it can happen that you can no longer read the numbers.

@bembelimen To make it easy: why not link to the Joomla updater?

I would be confused if a current version number would link to the updater. I would rather assume a further information about the version or a changelog here.


But I also think that there is a misunderstanding or that I do not have all the information. I had asked above, but did not get an answer. At the moment the module does nothing but show the installed version. There is no warning. The description of the module says so too. For a warning regarding an outdated installation, the Quickicon is responsible, right?

Modules  Joomla  Version Information   test   Administration
Plugins   test   Administration

avatar Quy
Quy - comment - 7 Oct 2019

How about adding text-muted to imply it is not clickable?

26447

avatar N6REJ
N6REJ - comment - 7 Oct 2019

@astridx I don't think you understood what I meant. Here is what I meant.
desktop
mobile

avatar infograf768
infograf768 - comment - 8 Oct 2019

For a warning regarding an outdated installation, the Quickicon is responsible, right?

To all: yes it is but please re-read my comment above
#26447 (comment)

avatar N6REJ
N6REJ - comment - 8 Oct 2019

@infograf768 since the message modal pops up to top I wouldn't see why it couldn't be used.

avatar infograf768
infograf768 - comment - 9 Oct 2019

@infograf768 since the message modal pops up to top I wouldn't see why it couldn't be used.

Not sure what you mean.
We have no message when an update (joomla, extensions, overrides, urgent privacy requests) is available. The new Quickicon system does not provide for such messages.
updatemessage

To obtain such messages, I guess an important refactoring would be necessary.

avatar wilsonge
wilsonge - comment - 19 Oct 2019

#26734 Added the text-muted property proposed by @Quy as it seems like a better way to demonstrate the fact it's not clickable

avatar wilsonge wilsonge - change - 19 Oct 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-10-19 22:47:15
Closed_By wilsonge
Labels Removed: ?
avatar wilsonge wilsonge - close - 19 Oct 2019

Add a Comment

Login with GitHub to post a comment