User tests: Successful: Unsuccessful:
Pull Request for Issue #26373.
I changed the position of the module that displayed the version number to the bottom.
I changed the position of the module that displayed the version number. See #26447 (comment)
Apply this patch.
Make a new installation (Have to update SQL in order for the patch to work).
See, that the version number is now on the right side of the bottom at the top right corner.
See, that no version number is displayed in the top menu.
No
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Language & Strings Modules Templates (admin) SQL Installation Postgresql |
Title |
|
Labels |
Added:
?
?
|
I have tested this item
If you made a "new" installation the patch wouldn't exist
I did
-git reset --hard
-git pull -f
-add patch
-npm ci
test.
There is no 'error' that was displayed. If you look where the version WAS you'll see that its just messy text now.
I have tested this item
Must manually update SQL in order for the patch to work.
might want to modify the testing instructions
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
I'm not convinced we want this? Part of the design of the new template is to remove the footer. Why is having the version in the header so totally wrong?
I felt like @N6REJ .
Is there a reason why the footer was removed?
Addition: It is not a real footer. It will be displayed under the content:
I agree that currently it looks like its something you should click on
I agree that it probably doesn't need to be so prominent
I dont agree with this PR for the reason shown in your last screenshot
Labels |
Added:
?
|
depends if you publish that module
it's pre-published during install brian
Did you do the test also on your smartphones?
The module should add a warning the version number if the version ist not up to date.
It was expected that people see this better in in the prominent place in the header.
You can ask if it is necessary - but we want that every Joomla Version is always up to date. No casual user will search for the version number in the stats module or system information.
@chmst Thank you for checking.
For me it looks like this on the Smartphone:
But you are right. I did not test it correctly. If the screen width is less than 460px or debug mode is enabled, the version number disappears. That's why I gave the element with the version number a margin and a padding in the last commit. Now it looks like this:
Without the version number we could perhaps position the buttons in the mobile foot menu directly and you would not have to open something extra.
What exactly do you mean with:
The module adds a warning badge to the version number if the version ist not up to date.
I can not find a program code in the module that displays a warning if the version is outdated. Can you point me there please?
Without knowing the code, I wonder if the Quick-icon and the Joomla Updater update-hint are not enough to inform the user about an existing new version.
Status | Ready to Commit | ⇒ | Pending |
Labels |
Removed:
?
|
Category | Administration Language & Strings Modules Templates (admin) SQL Installation Postgresql | ⇒ | Administration Language & Strings Modules Templates (admin) JavaScript Repository NPM Change SQL Installation Postgresql |
Labels |
Added:
NPM Resource Changed
|
I just added more changes. The top menu in the "footer" has now the following changes (for me improvements):
Before, there was often free space in the bar, although other icons were available.
That was already so before. My change: It does not happen that icons are hidden like in this picture:
I hope I did not miss something again.
@N6REJ @alikon Would you please test again with this changes?
I am concerned by the position of the Update Checks module in the Control Panel page. This before and after this patch. But it’s even worse when a unique column is used in smaller screens.
In 3.x we have an alert/message always displaying on top of the page. In 4.0 it is very easy to miss that module as one has to scroll a lot to be informed about updates.
Is there a way (by js as it looks like we can’t avoid these complex js for almost all in J4) to move that entire module to top when there are updates?
Sorry, I fully disagree with this PR.
This PR does not deliver any benefits to the system. It just make the current version less visible + implements a footer where we don't want any footer.
I think we should raise awareness to the installed version + should always point out if the version is out of date.
Additionally if you check the Joomla! 3 version and compare with Joomla! 4 you'll see, that the version button is now an own module, so if it's annoys you, you can disable it with one click.
But version in the footer? No!
Perhaps we can adjust the module in header that way, that it does not look clickable (which is given imho, because there is absolute no indication, that this icon is clickable)
maybe there is some other way to make it look less like a button?
I agree that the appearance of the version module needs to be improved.
But do not see any advantage in moving the module to a footer. In modern applications I am used to find all mstatus informations top right not some information on the top, some at the end of the screen.
It seems not ergonomic to me, the eye must search for the information above the screen.
As @bembelimen says, you can move the module at the end of your dashboard.
Category | Administration Language & Strings Modules Templates (admin) SQL Installation Postgresql JavaScript Repository NPM Change | ⇒ | Administration Language & Strings Modules Templates (admin) SQL Installation Postgresql |
Labels |
Removed:
NPM Resource Changed
|
Category | Administration Language & Strings Modules Templates (admin) SQL Installation Postgresql | ⇒ | Modules Administration Templates (admin) SQL Installation Postgresql |
To make it easy: why not link to the Joomla updater?
why not to the right of the J! icon? Wouldn't that make the most sense?
or as a tooltip for the J! icon?
@N6REJ why not to the right of the J! icon?
because most voted for the top right and because the space on a narrow display is better used. I tried it:
I also put it in the SVG logo as <text>
. But then it can happen that you can no longer read the numbers.
@bembelimen To make it easy: why not link to the Joomla updater?
I would be confused if a current version number would link to the updater. I would rather assume a further information about the version or a changelog here.
But I also think that there is a misunderstanding or that I do not have all the information. I had asked above, but did not get an answer. At the moment the module does nothing but show the installed version. There is no warning. The description of the module says so too. For a warning regarding an outdated installation, the Quickicon is responsible, right?
For a warning regarding an outdated installation, the Quickicon is responsible, right?
To all: yes it is but please re-read my comment above
#26447 (comment)
@infograf768 since the message modal pops up to top I wouldn't see why it couldn't be used.
@infograf768 since the message modal pops up to top I wouldn't see why it couldn't be used.
Not sure what you mean.
We have no message when an update (joomla, extensions, overrides, urgent privacy requests) is available. The new Quickicon system does not provide for such messages.
To obtain such messages, I guess an important refactoring would be necessary.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-19 22:47:15 |
Closed_By | ⇒ | wilsonge | |
Labels |
Removed:
?
|
TY TY TY TY TY, I think I put an issue in for this...or maybe I just ranted