[#26439] - "Edit Category" string
- Fixed in Code Base
- 19 Oct 2019
- Medium
- Build: staging
- # 26439
- Diff
- SharkyKZ:patch-2
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Currently "Edit Category" string used in articles/featured view is glued out of two separate strings. This is not translatable in some languages.
Testing Instructions
"Edit Category" text still appears when hovering over category in articles/featured view in backend.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content Language & Strings |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26439.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26439.
I am sure there will be other strings constructed this way
I am sure there will be other strings constructed this way
Shouldn't we then go a way like:
JEDIT_ITEM="Edit %s"
Shouldn't we then go a way like:
JEDIT_ITEM="Edit %s"
I’m afraid it would not be a good idea, as the semantics depend on the language.
Shouldn't we then go a way like:
JEDIT_ITEM="Edit %s"I’m afraid it would not be a good idea, as the semantics depend on the language.
Yeah, that's why the placeholder %s. So English would be Edit %s and German would be
%s bearbeiten
In some languages the placeholder may be different depending on its use in a sentence. This, for example, would not work in some languages:
Text::sprintf('JEDIT_ITEM', Text::_('JCATEGORY'))
The point is not the placeholder variable here, but the verb “edit” which may need to be written differently depending on the variable. (This PR is fine.)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26439.
I have tested this item
Tested successfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26439.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26439.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-19 12:55:33 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks guys!
I have tested this item✅ successfully on d467522
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26439.