Feeling Lucky
?
[#2643] - Reverting not allowing spaces inside username
- Closed
- 4 Dec 2013
- Medium
- Build: master
- # 2643
- Diff
- infograf768:32883-master
- Foreign ID 32883
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
| Description | <p><a href="http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32883&start=0">http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32883&start=0</a></p> | ⇒ | <p><a href="http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32883&start=0">http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32883&start=0</a></p> <p>PR for master</p> |
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2013-12-04 16:36:22 |
| Labels |
Added:
?
|
||
dbhurley
- comment
- 4 Dec 2013
This is not yet ready for merge. It needs tests and review please first.
Bakual
- comment
- 4 Dec 2013
Yeah, my fault. Tried out SmartGit and expected to merge into my clone...
elkuku
- comment
- 4 Dec 2013
Tried out SmartGit ...
Never trust a GUI 
betweenbrain
- comment
- 4 Dec 2013
No harm, no foul.
Bakual
- comment
- 4 Dec 2013
Phew. Think it is corrected now.
@infograf768 I think you need to recreate this PR as it can't be reopened. Or I don't see how?
Sorry all for the disturbing 
infograf768
- comment
- 5 Dec 2013
I have modified the PR to prevent spaces at beginning and end of username.
infograf768
- comment
- 5 Dec 2013
hmm. I recreate now
It looks like @infograf768 has some doubts to this PR, and there no were no tests. Was this merged by accident?