Joomla! Issue Tracker | Joomla! CMS #26423 - [4.0] Fixes cases of switchers double label

Fixed in Code Base
19 Oct 2019
Medium
Build: 4.0-dev
# 26423
Diff
wilsonge:bugfix/switcher-double-label

Pending

Pending Hound Hound is busy sniffing around... Details

User tests: Successful: Unsuccessful:

wilsonge
28 Sep 2019

Related to #26206

Summary of Changes

Removes some code added in #21227 which is now unused (the skipLabelFor attribute) as we now just outright don't render the label. Remove the check for the switcher class and instead add a class level flag to hide the label. It comes with clear documentation about the risks of using the flag.

This is the structural fix to the issue in the other PR. Once this is merged THEN we should merge #26206 to remove the useless labels

Testing Instructions

Go to the Tags component options and find the direction field.

Before Patch

After Patch

Documentation Changes Required

None

d92508d 28 Sep 2019

Flag for stopping a field from rendering the label

wilsonge - open - 28 Sep 2019

wilsonge - change - 28 Sep 2019

Status

New

⇒

Pending

joomla-cms-bot - change - 28 Sep 2019

Category

⇒

Layout Libraries

wilsonge - change - 28 Sep 2019

Title

…

Fixes cases of switchers double label

[4.0] Fixes cases of switchers double label

wilsonge - edited - 28 Sep 2019

930302e 28 Sep 2019

Merge branch '4.0-dev' into bugfix/switcher-double-label

rdeutz - change - 28 Sep 2019

Labels

Added: ?

uGE70 - test_item - 28 Sep 2019 - Tested successfully

uGE70 - comment - 28 Sep 2019

I have tested this item ✅ successfully on 930302e

- Go to Tags Options

Before Patch: label + legend tags are displayed
After Patch applied: only legend tag is dislayed
_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26423.}

SharkyKZ - comment - 28 Sep 2019

Doesn't solve the issue because since #25085 the label is always rendered for screen readers (hiddenLabel attribute only adds sr-only class). The simplest fix would be to change string comparison to a strpos() check here https://github.com/joomla/joomla-cms/pull/26423/files#diff-1a31ec6292bd41ba0bafe545bf8c1262L952 (and move it to RadioField class).

But, IMO, we should stop using class attribute to set layout and use layout attribute instead. There's PR #26214 for that.

wilsonge - comment - 29 Sep 2019

@SharkyKZ understood. But just for my own head - this isn’t any different to how the code functions now right?

SharkyKZ - comment - 29 Sep 2019

Sorry, I don't understand the question.

opn365 - test_item - 19 Oct 2019 - Tested unsuccessfully

opn365 - comment - 19 Oct 2019

I have tested this item ? unsuccessfully on 930302e

error applying patch
Patch could not be applied due to exception with layouts/joomla/form/renderlabel.php. Joomla\Filesystem\File::move: Rename failed.

using a pbf instance

Setting Value
PHP Built On Linux joomlapbf.directrouter.com 2.6.32-754.3.5.el6.x86_64 #1 SMP Tue Aug 14 20:46:41 UTC 2018 x86_64
Database Type mysql
Database Version 10.2.27-MariaDB
Database Collation utf8mb4_unicode_ci
Database Connection Collation utf8mb4_general_ci
PHP Version 7.2.23
Web Server Apache
WebServer to PHP Interface cgi-fcgi
Joomla! Version Joomla! 4.0.0-beta1-dev Development [ Amani ] 17-October-2019 20:21 GMT
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.120 Safari/537.36

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26423.}

opn365 - test_item - 19 Oct 2019 - Tested successfully

opn365 - comment - 19 Oct 2019

I have tested this item ✅ successfully on 930302e

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26423.}