? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
24 Sep 2019

Pull Request for Issue #26395.

Summary of Changes

Removes @package and @subpackage tags from core library files.

Testing Instructions

Code review.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 24 Sep 2019
avatar SharkyKZ SharkyKZ - change - 24 Sep 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Sep 2019
Category Libraries
ca2f6b2 24 Sep 2019 avatar SharkyKZ CS
avatar SharkyKZ SharkyKZ - change - 24 Sep 2019
Labels Added: ?
55f08b6 24 Sep 2019 avatar SharkyKZ CS
avatar richard67 richard67 - test_item - 25 Sep 2019 - Tested successfully
avatar richard67
richard67 - comment - 25 Sep 2019

I have tested this item successfully on 55f08b6

Covers all occurrences of "@Package" or "@subpackage" in PHP files below libraries/src of current staging.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26405.

avatar Quy Quy - test_item - 25 Sep 2019 - Tested successfully
avatar Quy
Quy - comment - 25 Sep 2019

I have tested this item successfully on 55f08b6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26405.

avatar Quy Quy - change - 25 Sep 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 25 Sep 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26405.

avatar richard67
richard67 - comment - 25 Sep 2019

What about the PHCS sniffer thing which Michael suggested in his issue in order to avoid such doc block content in future? Does anyone have the knowledge and mood and time to do that?

avatar SharkyKZ
SharkyKZ - comment - 26 Sep 2019

I can find time and maybe even mood but have no knowledge ?

avatar SharkyKZ
SharkyKZ - comment - 26 Sep 2019

Scribbled something up joomla/coding-standards#255.

avatar wilsonge wilsonge - change - 6 Oct 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-10-06 20:50:49
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 6 Oct 2019
avatar wilsonge wilsonge - merge - 6 Oct 2019
avatar wilsonge
wilsonge - comment - 6 Oct 2019

Thanks!

Add a Comment

Login with GitHub to post a comment