? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
23 Sep 2019

Ensure that the new json api code uses language strings and not hard coded text

code review

f2e73d7 23 Sep 2019 avatar brianteeman .
5a4499b 23 Sep 2019 avatar brianteeman .
2f68432 23 Sep 2019 avatar brianteeman sync
avatar brianteeman brianteeman - open - 23 Sep 2019
avatar joomla-cms-bot joomla-cms-bot - change - 23 Sep 2019
Category Administration Language & Strings Libraries
e07c958 23 Sep 2019 avatar brianteeman alpha
avatar brianteeman brianteeman - change - 23 Sep 2019
Labels Added: ? ?
1b3641e 23 Sep 2019 avatar brianteeman alpha
avatar Quy Quy - test_item - 23 Sep 2019 - Tested successfully
avatar Quy
Quy - comment - 23 Sep 2019

I have tested this item successfully on 1b3641e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26393.

avatar wilsonge
wilsonge - comment - 23 Sep 2019

Sorry are you able to fix conflicts - I finally found why the API tests were failing and fixed it - but broke this with the file rename

da21df1 24 Sep 2019 avatar brianteeman .
841c857 24 Sep 2019 avatar brianteeman sync
avatar joomla-cms-bot joomla-cms-bot - change - 24 Sep 2019
Category Administration Language & Strings Libraries Administration com_finder Language & Strings Modules Templates (admin)
avatar joomla-cms-bot joomla-cms-bot - change - 24 Sep 2019
Category Administration Language & Strings com_finder Modules Templates (admin) Administration Language & Strings Libraries
avatar brianteeman
brianteeman - comment - 24 Sep 2019

@wilsonge conflicts fixed - just waiting to see if the tests complete successfully

avatar brianteeman
brianteeman - comment - 24 Sep 2019

all tests passed. as this last change was just to resolve merge conflicts it is probably rtc

avatar wilsonge wilsonge - close - 24 Sep 2019
avatar wilsonge wilsonge - merge - 24 Sep 2019
avatar wilsonge wilsonge - change - 24 Sep 2019
Status New Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-09-24 11:13:49
Closed_By wilsonge
avatar wilsonge
wilsonge - comment - 24 Sep 2019

Thanks!

avatar brianteeman
brianteeman - comment - 24 Sep 2019

thanks

Add a Comment

Login with GitHub to post a comment