? Pending

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
22 Sep 2019

Pull Request for Issue # .

Summary of Changes

Adds a focus highlight to the switcher field when in focus.

Testing Instructions

Apply this patch and run node build.js --compile-css for updating the changed SCSS. Alternatively, you can run npm i.

Navgiate to a page using the switcher (global config). Tab until switcher in focus.

Before

image

After

image

Documentation Changes Required

avatar ciar4n ciar4n - open - 22 Sep 2019
avatar ciar4n ciar4n - change - 22 Sep 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Sep 2019
Category Repository NPM Change
avatar richard67 richard67 - test_item - 22 Sep 2019 - Tested successfully
avatar richard67
richard67 - comment - 22 Sep 2019

I have tested this item successfully on 7285b68

A small step counted in code lines, but a giant leap for the switcher ;-)

But now after this test I need a new keyboard, the tab key is worn-out.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26377.

avatar Quy Quy - test_item - 23 Sep 2019 - Tested successfully
avatar Quy
Quy - comment - 23 Sep 2019

I have tested this item successfully on 7285b68


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26377.

avatar Quy Quy - change - 23 Sep 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 23 Sep 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26377.

avatar Quy
Quy - comment - 23 Sep 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26377.

avatar wilsonge wilsonge - close - 23 Sep 2019
avatar wilsonge wilsonge - merge - 23 Sep 2019
avatar wilsonge wilsonge - change - 23 Sep 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-09-23 22:46:00
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 23 Sep 2019

Thanks!

Add a Comment

Login with GitHub to post a comment