[#26371] - [4.0] Dropdowns don't drop OVER the items below
- Fixed in Code Base
- 16 Oct 2019
- Medium
- Build: 4.0-dev
- # 26371
- Diff
- N6REJ:dropdown-show
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
changes z-index so dropdowns go OVER the content below
Testing Instructions
install latest 4.0-dev.
go to components and click on the cog on "tags"
dropdown will be partially hidden.
install patch
run node build.js --compile-css
dropdown now fully visible
Expected result
Actual result
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
| Title |
|
||||||
| Labels |
Added:
?
|
||
I have tested this item
I tested the patch and it does not have the required effect.
The issue was not identical to what is described above: The Tags drop-down showed correct: it dropped down over the grey area but the Smart Search drop-down showed as above in the issue.
I tested in both Firefox 69.0.1 (Linux) and Chromium 77.0.3865.90 (Linux) and the results are the same. See picture. So after applying the patch, the issue is NOT fixed.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26371.
Testing instructions are not complete, it needs to run “npm install” after having applied the patch. Or am I wrong?
Yes the test instructions are wrong
No need to do a full npm install - it is enough to run
node build.js --compile-css
This will compile all the scss defined files and also create a minified version of the css
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26371.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26371.
Yes, node build.js --compile-css is absolutely sufficient ... but npm install is easier to remember for me ;-)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26371.
@Thomsterdam Please change your test result in the issue tracker to "Not tested" so maintainers don't get confused by the negative test (which was wrong due to wrong testing instructions).
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26371.
do I need to change something guys?
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-16 20:59:46 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
I tested the patch and it does not have the required effect.
The issue was not identical to what is described above: The Tags drop-down showed correct: it dropped down over the grey area but the Smart Search drop-down showed as above in the issue.
I tested in both Firefox 69.0.1 (Linux) and Chromium 77.0.3865.90 (Linux) and the results are the same. See picture. So after applying the patch, the issue is NOT fixed.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26371.