[#26369] - [4.0] RTL: Fixing template editors text-align
- Fixed in Code Base
- 30 Sep 2019
- Medium
- Build: 4.0-dev
- # 26369
- Diff
- infograf768:4.0_templates_edit_rtl
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
When editing template files in RTL, the text content should be aligned left.
Adding rtl overrides in .../build/media_source/com_templates/css/admin-templates-default.css both for Codemirror and no editor
Testing Instructions
Edit a template file through administration.
No need to test with Persian language. Simpler in this case to set en-GB.xml to rtl
<rtl>1</rtl>
Before patch
After patch
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
| Category | Repository NPM Change | ⇒ | Administration com_templates Repository NPM Change |
Space corrected.
While I was at it and to avoid another very small PR, I also corrected the display of the path of the edited file.
Before
The slash is misplaced at the end of the path.
After
The position of the slash is corrected
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26369.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26369.
| Status | Pending | ⇒ | Ready to Commit |
rtc
thanks for testing
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26369.
| Labels |
Added:
?
|
||
I think it's probably better to do this in javascript than CSS. But right now I don't have the time to find how to do this properly in all places. So merging. If anyone has the time to try and put this into JS please do!
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-09-30 12:50:03 |
| Closed_By | ⇒ | wilsonge |
Thanks!
I have tested this item✅ successfully on 4abca42
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26369.